linux-kernel - Re: [PATCH] media: pvrusb2: fix DVB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2f310818-7b19-4c07-9948-d5e413989594@app.fastmail.com>
Date:   Wed, 18 Jan 2023 16:57:19 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Mike Isely at pobox" <isely@...ox.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Lecopzer Chen" <lecopzer.chen@...iatek.com>,
        "Hans Verkuil" <hverkuil-cisco@...all.nl>,
        Łukasz Stelmach <l.stelmach@...sung.com>,
        "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
        "Jacopo Mondi" <jacopo@...ndi.org>,
        "Andrzej Pietrasiewicz" <andrzejtp2010@...il.com>,
        linux-media@...r.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: pvrusb2: fix DVB_CORE dependency

On Wed, Jan 18, 2023, at 16:39, Mike Isely wrote:
> That doesn't seem right.  The pvrusb2 module should reference that 
> symbol like any other.  There is no special treatment of it within 
> pvrusb2 - so why is that requiring special treatment here?

The problem is that VIDEO_PVRUSB2_DVB is a 'bool' symbol, not
a 'tristate', so the existing 'depends on DVB_CORE' is not sufficient.

Another way to do this would be to prevent VIDEO_PVRUSB2 from
being built-in when DVB_CORE is a module:

 config VIDEO_PVRUSB2
        tristate "Hauppauge WinTV-PVR USB2 support"
        depends on VIDEO_DEV && I2C
+       depends on DVB_CORE || !DVB_CORE
        select VIDEO_TUNER
        select VIDEO_TVEEPROM
        select VIDEO_CX2341X

but that doesn't feel right for users that don't care about DVB
support.

> Is it possible that dvb_module_probe and dvb_module_release are not 
> exported?  (Or that there are two corresponding different exported 
> symbol names that pvrusb2 should be using instead?)

No.

   Arnd