[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8gX0krXayfOa4Hi@smile.fi.intel.com>
Date: Wed, 18 Jan 2023 18:01:22 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Wolfram Sang <wsa@...nel.org>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Peter Rosin <peda@...ntia.se>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Michael Tretter <m.tretter@...gutronix.de>,
Shawn Tu <shawnx.tu@...el.com>,
Hans Verkuil <hverkuil@...all.nl>,
Mike Pagano <mpagano@...too.org>,
Krzysztof HaĆasa <khalasa@...p.pl>,
Marek Vasut <marex@...x.de>
Subject: Re: [PATCH v7 0/7] i2c-atr and FPDLink
On Wed, Jan 18, 2023 at 02:40:24PM +0200, Tomi Valkeinen wrote:
> Hi,
>
> You can find the v6 from:
>
> https://lore.kernel.org/all/20230105140307.272052-1-tomi.valkeinen@ideasonboard.com/
>
> Main changes:
>
> * i2c-atr: Use bus notifier. This allows us to drop the patch that adds
> the attach_client/detach_client callbacks. On the downside, it removes
> the option for error handling if the translation setup fails, and also
> doesn't provide us the pointer to the i2c_board_info. I belive both
> are acceptable downsides.
>
> * Use fwnode in the fpdlink drivers instead of OF
>
> * Addressed all the review comments (I hope)
>
> * Lots of cosmetic or minor fixes which I came up while doing the fwnode
> change
I believe my comments to the first driver applies to the next two, so please
address them whenever you are agree / it's possible / it makes sense.
About ATR implementation. We have the i2c bus (Linux representation of
the driver model) and i2c_adapter and i2c_client objects there. Can't we
have an i2c_client_aliased in similar way and be transparent with users?
It's just a thought which may be well far from the possibility
to be implemented if even possible...
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists