linux-kernel - Re: [PATCH] ktest.pl: Fix missing "end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230118114340.704eca59@gandalf.local.home>
Date:   Wed, 18 Jan 2023 11:43:40 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] ktest.pl: Fix missing "end_monitor" when machine check
 fails

On Wed, 18 Jan 2023 11:43:01 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
> 
> In the "reboot" command, it does a check of the machine to see if it is
> still alive with a simple "ssh echo" command. If it fails, it will assume
> that a normal "ssh reboot" is not possible and force a power cycle.
> 
> In this case, the "start_monitor" is executed, but the "end_monitor" is
> not, and this causes the screen not to be given back to the console. That
> is, after the test, a "reset" command needs to be performed, as "echo" is
> turned off.
> 
> Fixes: 6474ace999edd ("ktest.pl: Powercycle the box on reboot if no connection can be made")
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> ---

Masami, I believe this will fix your issue with the console after running
the test.

-- Steve