linux-kernel - Re: [PATCHv2] mm: use stack_depot_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGWkznEusXRmi=ZEOvfK8qRfe+aKWa3X-bLG28=XoeGZ5umeuQ@mail.gmail.com>
Date:   Wed, 18 Jan 2023 09:40:03 +0800
From:   Zhaoyang Huang <huangzhaoyang@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     "zhaoyang.huang" <zhaoyang.huang@...soc.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Nathan Chancellor <nathan@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, ke.wang@...soc.com,
        Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
Subject: Re: [PATCHv2] mm: use stack_depot_early_init for kmemleak

On Wed, Jan 18, 2023 at 9:31 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Wed, 18 Jan 2023 09:25:48 +0800 Zhaoyang Huang <huangzhaoyang@...il.com> wrote:
>
> > On Wed, Jan 18, 2023 at 8:17 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
> > >
> > > On Tue, 17 Jan 2023 16:11:52 +0800 "zhaoyang.huang" <zhaoyang.huang@...soc.com> wrote:
> > >
> > > > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc.
> > > > Solve this by having stackdepot use stack_depot_early_init. Extra Kconfig also
> > > > done by moving kmemleak stuff to mm/Kconfig.debug.
> > >
> > > I don't understand - what was the reason for the Kconfig change?
> > The items related to kmemleak are moved from lib/Kconfig.debug to
> > mm/Kconfig.debug
>
> Well yes, but why?
It was suggested by Vlastimil in a previous comment. It makes more
sense to have kmemleak's source code and Kconfig items under the same
directory.
>
> Is that related to this bug fix?  If not then please let's have that
> change in a separate patch.
The moved items are updated for this bug fix.
>