linux-kernel - Re: [PATCH -next] evm: Support small xattr in dump_security

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba437ae5bd782ec2a6a8351f4c667aa16014af97.camel@linux.ibm.com>
Date:   Wed, 18 Jan 2023 15:23:43 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>, dmitry.kasatkin@...il.com,
        paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] evm: Support small xattr in dump_security_xattr()

Hi Xiu,

Thank you for cleaning up the code.  The purpose of this patch is to
remove code duplication.   Perhaps rename the patch to "evm: call
dump_security_xattr() in all cases to remove code duplication".

On Mon, 2022-12-26 at 18:24 +0800, Xiu Jianfeng wrote:
> Currently the debug function of dumping xattr is splited into two parts,
> when the length of xattr is less than 64 bytes, it uses pr_debug()
> directly. Merge it into dump_security_xattr() to simplify the code, no
> functional changes here.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Please reword the patch description in terms of removing code
duplication.

-- 
thanks,

Mimi