linux-kernel - RE: [PATCH 2/2] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xRU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN0PR12MB6101BA7BD23547F8E797DB46E2C79@MN0PR12MB6101.namprd12.prod.outlook.com>
Date:   Wed, 18 Jan 2023 20:50:12 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Raul E Rangel <rrangel@...omium.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
        Werner Sembach <wse@...edocomputers.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] gpiolib: acpi: Add a ignore wakeup quirk for Clevo
 NL5xRU

[Public]



> -----Original Message-----
> From: Linus Walleij <linus.walleij@...aro.org>
> Sent: Wednesday, January 18, 2023 14:45
> To: Limonciello, Mario <Mario.Limonciello@....com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; Bartosz Golaszewski
> <brgl@...ev.pl>; Dmitry Torokhov <dmitry.torokhov@...il.com>; Raul E
> Rangel <rrangel@...omium.org>; Benjamin Tissoires
> <benjamin.tissoires@...hat.com>; regressions@...ts.linux.dev; Werner
> Sembach <wse@...edocomputers.com>; linux-gpio@...r.kernel.org; linux-
> acpi@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] gpiolib: acpi: Add a ignore wakeup quirk for Clevo
> NL5xRU
> 
> On Mon, Jan 16, 2023 at 8:37 PM Mario Limonciello
> <mario.limonciello@....com> wrote:
> 
> > However on Clevo NL5xRU there is a mistake in the ACPI tables that the
> > TP_ATTN# signal connected to GPIO 9 is configured as ActiveLow and level
> > triggered but connected to a pull up. As soon as the system suspends the
> > touchpad loses power and then the system wakes up.
> 
> Now that is what I call proper root cause analysis. Hats off for this patch!
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Raul should get some credit too here in the confirmation on that root cause.

It certainly really helps that the schematics for this system were readily available
on the web to confirm the hypothesis.