linux-kernel - Re: [PATCH net-next] wifi: airo: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202301181022195938376@zte.com.cn>
Date:   Wed, 18 Jan 2023 10:22:19 +0800 (CST)
From:   <yang.yang29@....com.cn>
To:     <johannes@...solutions.net>
Cc:     <kvalo@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>,
        <akpm@...ux-foundation.org>, <songmuchun@...edance.com>,
        <brauner@...nel.org>, <julia.lawall@...ia.fr>,
        <gustavoars@...nel.org>, <jason@...c4.com>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <xu.panda@....com.cn>
Subject: Re: [PATCH net-next] wifi: airo: use strscpy() to instead of strncpy()

> Again, why bother. But is this even correct/identical behaviour?>>
> Wouldn't it potentially read 17 input bytes before forcing NUL-
> termination?

Thank you for your reminder. This is a terrible error. Strscpy() may
cause the array to be out of bounds. I should be more cautious
next time.

Xu and Yang