[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7bfd7a4b-95fd-0e95-70a9-7287ddbd3a8c@linaro.org>
Date: Wed, 18 Jan 2023 05:29:17 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
devicetree@...r.kernel.org
Cc: robdclark@...il.com, quic_abhinavk@...cinc.com, sean@...rly.run,
airlied@...il.com, daniel@...ll.ch, robh+dt@...nel.org,
dianders@...omium.org, david@...t.cz,
krzysztof.kozlowski+dt@...aro.org, swboyd@...omium.org,
konrad.dybcio@...ainline.org, agross@...nel.org,
andersson@...nel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/3] dt-bindings: msm: dsi-controller-main: Add
compatible strings for every current SoC
On 17/01/2023 00:52, Bryan O'Donoghue wrote:
> Currently we do not differentiate between the various users of the
> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
> compatible string but, the hardware does have some significant differences
> in the number of clocks.
>
> To facilitate documenting the clocks add the following compatible strings
>
> - qcom,apq8064-dsi-ctrl
> - qcom,msm8916-dsi-ctrl
> - qcom,msm8953-dsi-ctrl
> - qcom,msm8974-dsi-ctrl
> - qcom,msm8996-dsi-ctrl
> - qcom,msm8998-dsi-ctrl
> - qcom,sc7180-dsi-ctrl
> - qcom,sc7280-dsi-ctrl
> - qcom,sdm660-dsi-ctrl
> - qcom,sdm845-dsi-ctrl
> - qcom,sm8150-dsi-ctrl
> - qcom,sm8250-dsi-ctrl
> - qcom,sm8350-dsi-ctrl
> - qcom,sm8450-dsi-ctrl
> - qcom,sm8550-dsi-ctrl
> - qcom,qcm2290-dsi-ctrl
>
> Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of the desired format while we
> do so.
>
> Several MDSS yaml files exist which document the dsi sub-node.
> For each existing SoC MDSS yaml, provide the right dsi compat string.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
> .../display/msm/dsi-controller-main.yaml | 30 ++++++++++++++++---
> .../bindings/display/msm/qcom,mdss.yaml | 3 +-
> .../display/msm/qcom,msm8998-mdss.yaml | 8 +++--
> .../display/msm/qcom,sc7180-mdss.yaml | 6 ++--
> .../display/msm/qcom,sc7280-mdss.yaml | 6 ++--
> .../display/msm/qcom,sdm845-mdss.yaml | 8 +++--
> .../display/msm/qcom,sm8150-mdss.yaml | 8 +++--
> .../display/msm/qcom,sm8250-mdss.yaml | 8 +++--
> .../display/msm/qcom,sm8350-mdss.yaml | 6 ++--
> .../display/msm/qcom,sm8450-mdss.yaml | 4 ++-
> 10 files changed, 63 insertions(+), 24 deletions(-)
[skipped]
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> index c268e0b662cf9..599a6bad80f43 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> @@ -46,7 +46,9 @@ patternProperties:
> type: object
> properties:
> compatible:
> - const: qcom,mdss-dsi-ctrl
> + items:
> + - const: qcom,sm8450-dsi-ctrl
> + - const: qcom,mdss-dsi-ctrl
>
> "^phy@[0-9a-f]+$":
> type: object
The example also should be updated in this file to include
qcom,sm8450-dsi-ctrl for DSI nodes
--
With best wishes
Dmitry
Powered by blists - more mailing lists