linux-kernel - Re: [PATCH v2] kheaders: ignore and clean temporary kheaders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARo4H+wKFMjd-DuzS33eV_i86bZW-S7s4Y4q7V7M7NA6w@mail.gmail.com>
Date:   Wed, 18 Jan 2023 14:02:45 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        Nicolas Schier <n.schier@....de>
Subject: Re: [PATCH v2] kheaders: ignore and clean temporary kheaders_data directory

On Wed, Jan 18, 2023 at 10:10 AM Thomas Weißschuh <linux@...ssschuh.net> wrote:
>
> On Tue, Jan 17, 2023 at 11:24:47PM +0900, Masahiro Yamada wrote:
> > On Tue, Jan 17, 2023 at 10:50 PM Thomas Weißschuh <linux@...ssschuh.net> wrote:
> > >
> > > If the kheaders archive generation is interrupted then this directory
> > > may be left.
> > > Ignore it, it will be deleted by the next run of kernel/gen_kheaders.sh.
> > > Also add it to clean-files so it can be cleaned up by make.
> > >
> > > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> >
> >
> > Or, just rename the temporary directory.
> > For example,
> >
> >   cpio_dir=$outdir/$(dirname $tarfile)/.tmp_cpio_dir
> >
> >
> >
> > Dot files are ignored.
> > 'make clean' removes the .tmp_* pattern.
>
> This sounds great.
>
> Unfortunately 'make clean' only cleans files and not directories based
> on this pattern.


Agh, you are right.

Can you extend .tmp_* to match any file type?

Maybe, something like this?


 \( -name '*.[aios]' -o [snip] '*.*.symversions' \) -type f -print
-o -name '.tmp_*' -print





>
> Should it be extended?
>
> > > ---
> > > Changes in v2:
> > > - Also add the directory to clean-files
> > > - Link to v1: https://lore.kernel.org/r/20230117-kernel-kheaders-gitignore-v1-1-2a3a070efd0d@weissschuh.net
> > > ---
> > >  kernel/.gitignore | 1 +
> > >  kernel/Makefile   | 2 +-
> > >  2 files changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/kernel/.gitignore b/kernel/.gitignore
> > > index c6b299a6b786..57ab1d703763 100644
> > > --- a/kernel/.gitignore
> > > +++ b/kernel/.gitignore
> > > @@ -1,3 +1,4 @@
> > >  # SPDX-License-Identifier: GPL-2.0-only
> > >  /config_data
> > >  /kheaders.md5
> > > +/kheaders_data.tar.xz.tmp/
> > > diff --git a/kernel/Makefile b/kernel/Makefile
> > > index 10ef068f598d..f3535944f635 100644
> > > --- a/kernel/Makefile
> > > +++ b/kernel/Makefile
> > > @@ -156,4 +156,4 @@ quiet_cmd_genikh = CHK     $(obj)/kheaders_data.tar.xz
> > >  $(obj)/kheaders_data.tar.xz: FORCE
> > >         $(call cmd,genikh)
> > >
> > > -clean-files := kheaders_data.tar.xz kheaders.md5
> > > +clean-files := kheaders_data.tar.xz kheaders.md5 kheaders_data.tar.xz.tmp
> > >
> > > ---
> > > base-commit: d532dd102151cc69fcd00b13e5a9689b23c0c8d9
> > > change-id: 20230117-kernel-kheaders-gitignore-f0d73456cb6b
> > >
> > > Best regards,
> > > --
> > > Thomas Weißschuh <linux@...ssschuh.net>



-- 
Best Regards
Masahiro Yamada