linux-kernel - Re: [PATCH v6] x86/sev: Add SEV-SNP guest feature negotiation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <086444df-568b-d394-c190-9f206cad9222@amd.com>
Date:   Wed, 18 Jan 2023 11:41:23 +0530
From:   "Nikunj A. Dadhania" <nikunj@....com>
To:     linux-kernel@...r.kernel.org, x86@...nel.org, kvm@...r.kernel.org,
        bp@...en8.de
Cc:     mingo@...hat.com, tglx@...utronix.de, dave.hansen@...ux.intel.com,
        seanjc@...gle.com, pbonzini@...hat.com, thomas.lendacky@....com,
        michael.roth@....com, zhi.wang.linux@...il.com,
        David Rientjes <rientjes@...gle.com>, stable@...nel.org
Subject: Re: [PATCH v6] x86/sev: Add SEV-SNP guest feature negotiation support



On 16/01/23 14:40, Nikunj A Dadhania wrote:
> +static void __noreturn sev_es_ghcb_terminate(struct ghcb *ghcb, unsigned int set,
> +					     unsigned int reason, u64 exit_info_2)
> +{

Found this today:

In file included from arch/x86/kernel/sev.c:519:
At top level:
arch/x86/kernel/sev-shared.c:167:24: warning: ‘sev_es_ghcb_terminate’ defined but not used [-Wunused-function]
  167 | static void __noreturn sev_es_ghcb_terminate(struct ghcb *ghcb, unsigned int set,
      |                        ^~~~~~~~~~~~~~~~~~~~~

I am wondering why I did not get this error in my build testing.

sev-shared.c gets included from two files boot/compressed/sev.c and kernel/sev.c, sev_es_ghcb_terminate() 
has only one user. I will move helper function to boot/compressed/sev.c and send an updated version.


Regards
Nikunj