[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <nycvar.YFH.7.76.2301180941320.1734@cbobk.fhfr.pm>
Date: Wed, 18 Jan 2023 09:41:45 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] HID: i2c-hid: use standard debugging APIs
On Fri, 23 Dec 2022, Thomas Weißschuh wrote:
> When trying to debug i2c-hid I was not able to use the builtin debug
> mechanism because the "debug" module parameter is not writable.
>
> We can change i2c-hid to use the standard kernel debugging APIs which are
> more discoverable and have more features.
>
> There is a bit of a stilistic conflict between consistently using
> i2c_hid_dbg() and consistently using dev_<level>().
>
> The second patch aligns debugging on i2c_hid_dbg().
> If this is unneeded, feel free to drop it.
>
> It would also be easy to just use dev_dbg() everywhere for consistency.
>
> To: Jiri Kosina <jikos@...nel.org>
> To: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: linux-input@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
>
> ---
> Thomas Weißschuh (2):
> HID: i2c-hid: switch to standard debugging APIs
> HID: i2c-hid: use uniform debugging APIs
>
> drivers/hid/i2c-hid/i2c-hid-core.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
Applied to for-6.3/i2c-hid branch, thanks Thomas.
--
Jiri Kosina
SUSE Labs
Powered by blists - more mailing lists