linux-kernel - Re: [PATCH v6 RESEND] HID: multitouch: Add quirks for flipped axes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2301181009100.1734@cbobk.fhfr.pm>
Date:   Wed, 18 Jan 2023 10:09:19 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Allen Ballway <ballway@...omium.org>
cc:     benjamin.tissoires@...hat.com, dmitry.torokhov@...il.com,
        dtor@...omium.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, rydberg@...math.org
Subject: Re: [PATCH v6 RESEND] HID: multitouch: Add quirks for flipped axes

On Tue, 10 Jan 2023, Allen Ballway wrote:

> Certain touchscreen devices, such as the ELAN9034, are oriented
> incorrectly and report touches on opposite points on the X and Y axes.
> For example, a 100x200 screen touched at (10,20) would report (90, 180)
> and vice versa.
> 
> This is fixed by adding device quirks to transform the touch points
> into the correct spaces, from X -> MAX(X) - X, and Y -> MAX(Y) - Y.
> 
> Signed-off-by: Allen Ballway <ballway@...omium.org>
> ---
> V5 -> V6: Add another IS_ENABLED check for CONFIG_I2C_DMI_CORE because
> the module may not be there at all.
> 
> V4 -> V5: Add IS_ENABLED check for CONFIG_DMI to prevent linker error.
> 
> V3 -> V4: Move quirk logic to i2c_hid_get_dmi_quirks and remove
> duplicate quirks from hid-multitouch.
> 
> V2 -> V3: Use existing HID_QUIRK_*_INVERT and match the quirk in
> hid-quirk, passing down to hid-multitouch through the hid device.
> 
> V1 -> V2: Address review comments, change to use DMI match. Confirmed
> MT_TOOL_X/Y require transformation and update orientation based on
> flipped axes.

Appplied, thank you.

-- 
Jiri Kosina
SUSE Labs