linux-kernel - Re: [PATCH v1 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8fDr2aM8z8Nm1z2@smile.fi.intel.com>
Date:   Wed, 18 Jan 2023 12:02:23 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Nuno Sá <nuno.sa@...log.com>,
        linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name

On Wed, Jan 18, 2023 at 10:29:50AM +0100, Marijn Suijten wrote:
> On 2023-01-18 09:46:14, Andy Shevchenko wrote:
> > On Wed, Jan 18, 2023 at 12:12:04AM +0100, Marijn Suijten wrote:
> > > On 2023-01-17 11:39:44, Andy Shevchenko wrote:

...

> > > > -	const char *name = fwnode_get_name(fwnode), *channel_name;
> > > > +	const char *name, *channel_name;
> > > 
> > > I don't think this'll compile as name is still a pointer to const data,
> > > while you're assigning (a '\0' char) to it below.
> > 
> > Right, it's always hard for me to compile things for ARM on x86 :-)
> > Thanks for catching this up!
> 
> Thanks for sending this in regardless; as said before I rather break ABI
> and clean the driver up properly (no more extend_name...) than sending a
> fix like this :)

Yes, but we need to backport something and ABI breakage is definitely not
an option for that.

> > But does this fix the issue after compilation fix?
> 
> It does, no more @xx in sysfs filenames nor label contents!

Okay, I'm about to send v2 and hopefully you can give your Tested-by.

-- 
With Best Regards,
Andy Shevchenko