| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <DM6PR12MB3082C8D0CC6AFFDA28F12E79E8C79@DM6PR12MB3082.namprd12.prod.outlook.com>
Date: Wed, 18 Jan 2023 10:59:15 +0000
From: "Gupta, Nipun" <Nipun.Gupta@....com>
To: Randy Dunlap <rdunlap@...radead.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"rafael@...nel.org" <rafael@...nel.org>,
"eric.auger@...hat.com" <eric.auger@...hat.com>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
"cohuck@...hat.com" <cohuck@...hat.com>,
"song.bao.hua@...ilicon.com" <song.bao.hua@...ilicon.com>,
"mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
"maz@...nel.org" <maz@...nel.org>,
"f.fainelli@...il.com" <f.fainelli@...il.com>,
"jeffrey.l.hugo@...il.com" <jeffrey.l.hugo@...il.com>,
"saravanak@...gle.com" <saravanak@...gle.com>,
"Michael.Srba@...nam.cz" <Michael.Srba@...nam.cz>,
"mani@...nel.org" <mani@...nel.org>,
"yishaih@...dia.com" <yishaih@...dia.com>,
"jgg@...pe.ca" <jgg@...pe.ca>, "jgg@...dia.com" <jgg@...dia.com>,
"robin.murphy@....com" <robin.murphy@....com>,
"will@...nel.org" <will@...nel.org>,
"joro@...tes.org" <joro@...tes.org>,
"masahiroy@...nel.org" <masahiroy@...nel.org>,
"ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC: "okaya@...nel.org" <okaya@...nel.org>,
"Anand, Harpreet" <harpreet.anand@....com>,
"Agarwal, Nikhil" <nikhil.agarwal@....com>,
"Simek, Michal" <michal.simek@....com>,
"git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH 01/19] bus/cdx: add the cdx bus driver
[AMD Official Use Only - General]
> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Tuesday, January 17, 2023 10:52 PM
> To: Gupta, Nipun <Nipun.Gupta@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; gregkh@...uxfoundation.org;
> rafael@...nel.org; eric.auger@...hat.com; alex.williamson@...hat.com;
> cohuck@...hat.com; song.bao.hua@...ilicon.com;
> mchehab+huawei@...nel.org; maz@...nel.org; f.fainelli@...il.com;
> jeffrey.l.hugo@...il.com; saravanak@...gle.com; Michael.Srba@...nam.cz;
> mani@...nel.org; yishaih@...dia.com; jgg@...pe.ca; jgg@...dia.com;
> robin.murphy@....com; will@...nel.org; joro@...tes.org;
> masahiroy@...nel.org; ndesaulniers@...gle.com; linux-arm-
> kernel@...ts.infradead.org; linux-kbuild@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Cc: okaya@...nel.org; Anand, Harpreet <harpreet.anand@....com>; Agarwal,
> Nikhil <nikhil.agarwal@....com>; Simek, Michal <michal.simek@....com>;
> git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH 01/19] bus/cdx: add the cdx bus driver
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi--
>
> On 1/17/23 05:41, Nipun Gupta wrote:
> > Introduce AMD CDX bus, which provides a mechanism for scanning
> > and probing CDX devices. These devices are memory mapped on
> > system bus for Application Processors(APUs).
> >
> > CDX devices can be changed dynamically in the Fabric and CDX
> > bus interacts with CDX controller to rescan the bus and
> > rediscover the devices.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> > Signed-off-by: Tarak Reddy <tarak.reddy@....com>
> > ---
> > Documentation/ABI/testing/sysfs-bus-cdx | 12 +
> > MAINTAINERS | 7 +
> > drivers/bus/Kconfig | 1 +
> > drivers/bus/Makefile | 2 +
> > drivers/bus/cdx/Kconfig | 14 +
> > drivers/bus/cdx/Makefile | 8 +
> > drivers/bus/cdx/cdx.c | 433 ++++++++++++++++++++++++
> > drivers/bus/cdx/cdx.h | 62 ++++
> > include/linux/cdx/cdx_bus.h | 153 +++++++++
> > include/linux/mod_devicetable.h | 15 +
> > scripts/mod/devicetable-offsets.c | 4 +
> > scripts/mod/file2alias.c | 12 +
> > 12 files changed, 723 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-bus-cdx
> > create mode 100644 drivers/bus/cdx/Kconfig
> > create mode 100644 drivers/bus/cdx/Makefile
> > create mode 100644 drivers/bus/cdx/cdx.c
> > create mode 100644 drivers/bus/cdx/cdx.h
> > create mode 100644 include/linux/cdx/cdx_bus.h
> >
>
> > diff --git a/drivers/bus/cdx/Kconfig b/drivers/bus/cdx/Kconfig
> > new file mode 100644
> > index 000000000000..54e0623ebcff
> > --- /dev/null
> > +++ b/drivers/bus/cdx/Kconfig
> > @@ -0,0 +1,14 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# CDX bus configuration
> > +#
> > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc.
> > +#
> > +
> > +config CDX_BUS
> > + bool "CDX Bus driver"
> > + help
> > + Driver to enable CDX Bus. CDX bus provides a mechanism for
> > + scanning and probing of CDX devices. CDX devices are memory
> > + mapped on system bus for embedded CPUs. CDX bus uses CDX
> > + controller and firmware to scan the CDX devices.
>
> Would you mind telling people who use 'make *config' what CDX means,
> either in the bool prompt string or in the help text?
Sure. Will update the help section for this.
>
>
> > +/**
> > + * cdx_unregister_device - Unregister a CDX device
> > + * @dev: CDX device
> > + * @data: This is always passed as NULL, and is not used in this API,
> > + * but is required here as the bus_for_each_dev() API expects
> > + * the passed function (cdx_unregister_device) to have this
> > + * as an argument.
> > + *
> > + * @return: -errno on failure, 0 on success.
>
> The syntax (or spelling) for a function's return value in kernel-doc is just:
> * Return: -errno on failure, 0 on success.
>
> That should be changed in many places throughout.
Agree. Will update at all places.
Thanks,
Nipun
>
> Thanks.
>
> --
> ~Randy
Powered by blists - more mailing lists