linux-kernel - Re: [PATCH 1/2] pinctrl: mediatek: Initialize variable pullen and pullup to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8a19ad0-4db9-2c8b-d9db-63a0831dde52@collabora.com>
Date:   Wed, 18 Jan 2023 12:26:20 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Guodong Liu <Guodong.Liu@...iatek.com>,
        Sean Wang <sean.wang@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Light Hsieh <light.hsieh@...iatek.com>,
        Rob Herring <robh@...nel.org>
Cc:     linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Zhiyong Tao <zhiyong.tao@...iatek.com>
Subject: Re: [PATCH 1/2] pinctrl: mediatek: Initialize variable pullen and
 pullup to zero

Il 18/01/23 07:20, Guodong Liu ha scritto:
> Coverity spotted that pullen and pullup is not initialized to zero in
> mtk_pctrl_show_one_pin. The uninitialized variable pullen is used in
> assignment statement "rsel = pullen;" in mtk_pctrl_show_one_pin, and
> Uninitialized variable pullup is used when calling scnprintf. Fix this
> coverity by initializing pullen and pullup as zero.
> 
> Fixes: 184d8e13f9b1 ("pinctrl: mediatek: Add support for pin configuration
> dump via debugfs.")
> Signed-off-by: Guodong Liu <Guodong.Liu@...iatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>