linux-kernel - Re: [PATCH V3] dmaengine: Fix double increment of client_count in dma_chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8fg44HzvwY3Bb8N@matsya>
Date:   Wed, 18 Jan 2023 17:36:59 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Koba Ko <koba.ko@...onical.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jerry Snitselaar <jsnitsel@...hat.com>,
        Jie Hai <haijie1@...wei.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Joel Savitz <jsavitz@...hat.com>
Subject: Re: [PATCH V3] dmaengine: Fix double increment of client_count in
 dma_chan_get()

On 01-12-22, 11:00, Koba Ko wrote:
> The first time dma_chan_get() is called for a channel the channel
> client_count is incorrectly incremented twice for public channels,
> first in balance_ref_count(), and again prior to returning. This
> results in an incorrect client count which will lead to the
> channel resources not being freed when they should be. A simple
>  test of repeated module load and unload of async_tx on a Dell
>  Power Edge R7425 also shows this resulting in a kref underflow
>  warning.

Applied, thanks

-- 
~Vinod