linux-kernel - Re: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1dbfb913-95c3-c9c6-1797-e4d8387552ac@linaro.org>
Date:   Wed, 18 Jan 2023 13:26:04 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org
Cc:     marijn.suijten@...ainline.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow
 regulator-common properties



On 17.01.2023 09:51, Krzysztof Kozlowski wrote:
> On 16/01/2023 10:25, Konrad Dybcio wrote:
>> Allow regulator-common properties on lab/ibb regulators, such as
>> regulator-always-on, etc.
> 
> Are these proper regulators? If so this looks sensible. Why calling it
> RFC? What is here questionable?
I really had no idea if this was the proper way to do it, but
dt_bindings_check and CHECK_DTBS+example dt were happy..

> 
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>>  .../bindings/regulator/qcom-labibb-regulator.yaml           | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> index f97b8083678f..c0be7d5a6d40 100644
>> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> @@ -20,7 +20,8 @@ properties:
>>  
>>    lab:
>>      type: object
>> -    additionalProperties: false
>> +    $ref: "regulator.yaml#"
> 
> Drop quotes.
> 
>> +    unevaluatedProperties: false
>>  
>>      properties:
>>        qcom,soft-start-us:
>> @@ -46,7 +47,8 @@ properties:
>>  
>>    ibb:
>>      type: object
>> -    additionalProperties: false
>> +    $ref: "regulator.yaml#"
> 
> Drop quotes.
Ack x2

Konrad
> 
>> +    unevaluatedProperties: false
>>  
>>      properties:
>>        qcom,discharge-resistor-kohms:
> 
> Best regards,
> Krzysztof
>