linux-kernel - Re: [PATCH v1 1/1] platform/x86: int1092: Switch to use acpi_evaluate_dsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2023 20:56:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Shravan Sudhakar <s.shravan@...el.com>,
        Intel Corporation <linuxwwan@...el.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>
Subject: Re: [PATCH v1 1/1] platform/x86: int1092: Switch to use
 acpi_evaluate_dsm_typed()

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.2-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/platform-x86-int1092-Switch-to-use-acpi_evaluate_dsm_typed/20230118-184845
patch link:    https://lore.kernel.org/r/20230118095152.41427-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] platform/x86: int1092: Switch to use acpi_evaluate_dsm_typed()
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/6051c9fba08cdbd6ea1baeac8664b8f4462b427d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/platform-x86-int1092-Switch-to-use-acpi_evaluate_dsm_typed/20230118-184845
        git checkout 6051c9fba08cdbd6ea1baeac8664b8f4462b427d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/platform/x86/intel/int1092/intel_sar.c: In function 'sar_get_device_mode':
>> drivers/platform/x86/intel/int1092/intel_sar.c:134:13: warning: unused variable 'value' [-Wunused-variable]
     134 |         int value;
         |             ^~~~~


vim +/value +134 drivers/platform/x86/intel/int1092/intel_sar.c

dcfbd31ef4bcf6c Shravan S       2021-07-24  117  
dcfbd31ef4bcf6c Shravan S       2021-07-24  118  /**
dcfbd31ef4bcf6c Shravan S       2021-07-24  119   * sar_get_device_mode: Extraction of information from BIOS via DSM calls
dcfbd31ef4bcf6c Shravan S       2021-07-24  120   * @device: ACPI device for which to retrieve the data
dcfbd31ef4bcf6c Shravan S       2021-07-24  121   *
dcfbd31ef4bcf6c Shravan S       2021-07-24  122   * Retrieve the current device mode information from the BIOS.
dcfbd31ef4bcf6c Shravan S       2021-07-24  123   *
dcfbd31ef4bcf6c Shravan S       2021-07-24  124   * Return:
dcfbd31ef4bcf6c Shravan S       2021-07-24  125   * AE_OK on success
dcfbd31ef4bcf6c Shravan S       2021-07-24  126   * AE_ERROR on error
dcfbd31ef4bcf6c Shravan S       2021-07-24  127   */
dcfbd31ef4bcf6c Shravan S       2021-07-24  128  static acpi_status sar_get_device_mode(struct platform_device *device)
dcfbd31ef4bcf6c Shravan S       2021-07-24  129  {
dcfbd31ef4bcf6c Shravan S       2021-07-24  130  	struct wwan_sar_context *context = dev_get_drvdata(&device->dev);
dcfbd31ef4bcf6c Shravan S       2021-07-24  131  	acpi_status status = AE_OK;
dcfbd31ef4bcf6c Shravan S       2021-07-24  132  	union acpi_object *out;
dcfbd31ef4bcf6c Shravan S       2021-07-24  133  	u32 rev = 0;
dcfbd31ef4bcf6c Shravan S       2021-07-24 @134  	int value;
dcfbd31ef4bcf6c Shravan S       2021-07-24  135  
6051c9fba08cdbd Andy Shevchenko 2023-01-18  136  	out = acpi_evaluate_dsm_typed(context->handle, &context->guid, rev,
6051c9fba08cdbd Andy Shevchenko 2023-01-18  137  				      COMMAND_ID_DEV_MODE, NULL, ACPI_TYPE_INTEGER);
6051c9fba08cdbd Andy Shevchenko 2023-01-18  138  	if (!out) {
dcfbd31ef4bcf6c Shravan S       2021-07-24  139  		dev_err(&device->dev, "DSM cmd:%d Failed to retrieve value\n", COMMAND_ID_DEV_MODE);
dcfbd31ef4bcf6c Shravan S       2021-07-24  140  		status = AE_ERROR;
dcfbd31ef4bcf6c Shravan S       2021-07-24  141  		goto dev_mode_error;
dcfbd31ef4bcf6c Shravan S       2021-07-24  142  	}
6051c9fba08cdbd Andy Shevchenko 2023-01-18  143  	context->sar_data.device_mode = out->integer.value;
dcfbd31ef4bcf6c Shravan S       2021-07-24  144  	update_sar_data(context);
dcfbd31ef4bcf6c Shravan S       2021-07-24  145  	sysfs_notify(&device->dev.kobj, NULL, SYSFS_DATANAME);
dcfbd31ef4bcf6c Shravan S       2021-07-24  146  
dcfbd31ef4bcf6c Shravan S       2021-07-24  147  dev_mode_error:
dcfbd31ef4bcf6c Shravan S       2021-07-24  148  	ACPI_FREE(out);
dcfbd31ef4bcf6c Shravan S       2021-07-24  149  	return status;
dcfbd31ef4bcf6c Shravan S       2021-07-24  150  }
dcfbd31ef4bcf6c Shravan S       2021-07-24  151  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (294775 bytes)