linux-kernel - Re: [PATCH] ARM: mvebu: potential dereference of null pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8fxTCLpQ8mBAHzL@lunn.ch>
Date:   Wed, 18 Jan 2023 14:17:00 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     ye.xingchen@....com.cn
Cc:     gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, chi.minghao@....com.cn
Subject: Re: [PATCH] ARM: mvebu: potential dereference of null pointer

On Tue, Jan 17, 2023 at 06:22:04PM +0800, ye.xingchen@....com.cn wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> The return value of kzalloc() needs to be checked.
> To avoid use of null pointer in case of the failure of alloc.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  arch/arm/mach-mvebu/board-v7.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c
> index fd5d0c8ff695..b93b4a8a8357 100644
> --- a/arch/arm/mach-mvebu/board-v7.c
> +++ b/arch/arm/mach-mvebu/board-v7.c
> @@ -125,7 +125,8 @@ static void __init i2c_quirk(void)
>  		struct property *new_compat;
> 
>  		new_compat = kzalloc(sizeof(*new_compat), GFP_KERNEL);
> -
> +		if (!new_compat)
> +			return;
>  		new_compat->name = kstrdup("compatible", GFP_KERNEL);
>  		new_compat->length = sizeof("marvell,mv78230-a0-i2c");
>  		new_compat->value = kstrdup("marvell,mv78230-a0-i2c",

Please add a blank line after the return statement.

Also, i find it interested your bot is telling you about kzalloc, but
totally ignoring kstrdup().

	Andrew