linux-kernel - Re: [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to gcc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230119023337.h6a7f56lizhv4tcy@builder.lan>
Date:   Wed, 18 Jan 2023 20:33:37 -0600
From:   Bjorn Andersson <andersson@...nel.org>
To:     Rayyan Ansari <rayyan@...ari.sh>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: msm8226: add clocks and clock-names to
 gcc node

On Wed, Jan 18, 2023 at 06:08:52PM +0000, Rayyan Ansari wrote:
> Add the XO and Sleep Clock sources to the GCC node.
> 
> Signed-off-by: Rayyan Ansari <rayyan@...ari.sh>
> ---
>  arch/arm/boot/dts/qcom-msm8226.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index 4cba25dad8d6..c261fdfbe116 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -370,6 +370,11 @@ gcc: clock-controller@...00000 {
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;
> +
> +			clocks = <&xo_board>,

If I read the downstream sources [1] correctly, we're missing XO_CLK_SRC
among the 8974 rpm clocks. But that's what "xo" in &gcc should refer to.

Can you please define this clock and use it instead?

[1] https://source.codeaurora.org/quic/la/kernel/msm/tree/arch/arm/mach-msm/clock-8974.c?h=msm-3.4#n715

Regards,
Bjorn

> +				 <&sleep_clk>;
> +			clock-names = "xo",
> +				      "sleep_clk";
>  		};
>  
>  		mmcc: clock-controller@...c0000 {
> -- 
> 2.39.0
>