linux-kernel - Re: [PATCH v2 0/5] fsi: Add regmap and refactor sbefifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Jan 2023 11:48:48 -0600
From:   Eddie James <eajames@...ux.ibm.com>
To:     linux-fsi@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org, broonie@...nel.org,
        gregkh@...uxfoundation.org, rafael@...nel.org, jk@...abs.org,
        joel@....id.au, alistair@...ple.id.au
Subject: Re: [PATCH v2 0/5] fsi: Add regmap and refactor sbefifo


On 11/2/22 15:51, Eddie James wrote:
> The SBEFIFO hardware can now be attached over a new I2C endpoint interface
> called the I2C Responder (I2CR). In order to use the existing SBEFIFO
> driver, add a regmap driver for the FSI bus and an endpoint driver for the
> I2CR. Then, refactor the SBEFIFO and OCC drivers to clean up and use the
> new regmap driver or the I2CR interface.


I'm abandoning the rest of this series in favor of an FSI master driver 
through the I2C responder. It makes a lot more sense to implement a 
master driver here because then we get all the engine drivers for free, 
rather than rework them to talk over i2c.

Thanks,

Eddie


>
> Changes since v1:
>   - Instead of a regmap driver for the I2CR, just have a private interface
>     driver for FSI, since SBEFIFO is likely the only user.
>
> Eddie James (5):
>    regmap: Add FSI bus support
>    drivers: fsi: Add I2C Responder driver
>    drivers: fsi: Rename sbefifo and occ sources
>    drivers: fsi: separate char device code for occ and sbefifo
>    drivers: fsi: occ and sbefifo refactor
>
>   drivers/base/regmap/Kconfig      |    6 +-
>   drivers/base/regmap/Makefile     |    1 +
>   drivers/base/regmap/regmap-fsi.c |  231 ++++++
>   drivers/fsi/Kconfig              |   32 +-
>   drivers/fsi/Makefile             |    9 +-
>   drivers/fsi/fsi-occ.c            |  766 --------------------
>   drivers/fsi/fsi-sbefifo.c        | 1144 ------------------------------
>   drivers/fsi/i2cr.c               |  116 +++
>   drivers/fsi/i2cr.h               |   19 +
>   drivers/fsi/occ-cdev.c           |  157 ++++
>   drivers/fsi/occ.c                |  536 ++++++++++++++
>   drivers/fsi/occ.h                |   57 ++
>   drivers/fsi/sbefifo-cdev.c       |  218 ++++++
>   drivers/fsi/sbefifo-fsi.c        |   68 ++
>   drivers/fsi/sbefifo-i2c.c        |   73 ++
>   drivers/fsi/sbefifo.c            |  797 +++++++++++++++++++++
>   drivers/fsi/sbefifo.h            |   50 ++
>   include/linux/regmap.h           |   37 +
>   18 files changed, 2398 insertions(+), 1919 deletions(-)
>   create mode 100644 drivers/base/regmap/regmap-fsi.c
>   delete mode 100644 drivers/fsi/fsi-occ.c
>   delete mode 100644 drivers/fsi/fsi-sbefifo.c
>   create mode 100644 drivers/fsi/i2cr.c
>   create mode 100644 drivers/fsi/i2cr.h
>   create mode 100644 drivers/fsi/occ-cdev.c
>   create mode 100644 drivers/fsi/occ.c
>   create mode 100644 drivers/fsi/occ.h
>   create mode 100644 drivers/fsi/sbefifo-cdev.c
>   create mode 100644 drivers/fsi/sbefifo-fsi.c
>   create mode 100644 drivers/fsi/sbefifo-i2c.c
>   create mode 100644 drivers/fsi/sbefifo.c
>   create mode 100644 drivers/fsi/sbefifo.h
>