linux-kernel - Re: linux-next: build failure after merge of the tty.current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fea0fa6e-c2c6-f904-4e9b-94f40fa443ea@denx.de>
Date:   Thu, 19 Jan 2023 22:49:19 +0100
From:   Marek Vasut <marex@...x.de>
To:     Stephen Rothwell <sfr@...b.auug.org.au>, Greg KH <greg@...ah.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: linux-next: build failure after merge of the tty.current tree

On 1/19/23 21:58, Stephen Rothwell wrote:
> Hi all,

Hi,

> After merging the tty.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/tty/serial/stm32-usart.c: In function 'stm32_usart_interrupt':
> drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared (first use in this function)
>    804 |                 uart_unlock_and_check_sysrq_irqrestore(port, flags);
>        |                                                              ^~~~~
> drivers/tty/serial/stm32-usart.c:804:62: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>    f24771b62a83 ("serial: stm32: Merge hard IRQ and threaded IRQ handling into single IRQ handler")
> 
> I have used the tty.current tree from next-20230119 for today.

I already proposed a fix in the build robot report

[tty:tty-linus 4/7] drivers/tty/serial/stm32-usart.c:804:62: error: 
'flags' undeclared

Now waiting for Johan to confirm that's the correct approach.