[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8nCS8Z0QKzbeY2G@mail.local>
Date: Thu, 19 Jan 2023 23:20:59 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Dennis Lambe Jr <dennis@...rkcharge.io>
Cc: Alessandro Zummo <a.zummo@...ertech.it>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Atsushi Nemoto <atsushi.nemoto@...d.co.jp>,
Mylène Josserand
<mylene.josserand@...e-electrons.com>,
Gary Bisson <gary.bisson@...ndarydevices.com>,
Javier Martinez Canillas <javier@....samsung.com>,
Troy Kisky <troy.kisky@...ndarydevices.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rtc@...r.kernel.org
Subject: Re: [PATCH v3 1/3] rtc: m41t80: probe: use IS_ENABLED for CONFIG_OF
On 19/01/2023 21:39:01+0000, Dennis Lambe Jr wrote:
> The style guide recommends IS_ENABLED rather than ifdef for wrapping
> conditional code wherever possible.
>
> Functions that are only called on DeviceTree platforms would otherwise
> need to be cluttered up with __maybe_unused, which is especially
> undesirable if there's nothing inherently DT-specific about those
> functions.
>
> Signed-off-by: Dennis Lambe Jr <dennis@...rkcharge.io>
> ---
>
> Notes:
> v1 -> v2: spelling fix in changelog
>
> drivers/rtc/rtc-m41t80.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index 494052dbd39f..f963b76e5fc0 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c
> @@ -909,10 +909,11 @@ static int m41t80_probe(struct i2c_client *client)
> if (IS_ERR(m41t80_data->rtc))
> return PTR_ERR(m41t80_data->rtc);
>
> -#ifdef CONFIG_OF
> - wakeup_source = of_property_read_bool(client->dev.of_node,
> - "wakeup-source");
> -#endif
> + if (IS_ENABLED(CONFIG_OF)) {
> + wakeup_source = of_property_read_bool(client->dev.of_node,
> + "wakeup-source");
> + }
> +
A way better patch would switch to fwnode_property_read_bool
> if (client->irq > 0) {
> rc = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, m41t80_handle_irq,
> --
> 2.25.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists