linux-kernel - Re: [PATCH v2 0/4] Minor cleanup in msm8916 dts files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230119033428.ga6sbu42jaueac5o@builder.lan>
Date:   Wed, 18 Jan 2023 21:34:28 -0600
From:   Bjorn Andersson <andersson@...nel.org>
To:     Nikita Travkin <nikita@...n.ru>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 0/4] Minor cleanup in msm8916 dts files

On Mon, Jan 16, 2023 at 07:50:49PM +0500, Nikita Travkin wrote:
> This series performs some minor cleanup on msm8916/apq8016 files to
> bring them in line with the current standard and be closer to the new
> submissions.
> 
> The series is separated into commits by each specific change made across
> all files and these commits should not cause any functional difference.
> 
> Changes in v2:
> - Rebase on top of newly applied upstream patches
> 

The first patch looks pretty reasonable, but without documenting the
guidelines and tools to help others maintain the ordering this
unfortunately just moves things around arbitrarily.

Forgive me, but I will ignore this series until this is finalized and
documented.

Thanks,
Bjorn

> Nikita Travkin (4):
>   arm64: dts: qcom: msm/apq8x16-*: Move status property last
>   arm64: dts: qcom: msm/apq8x16-*: Reorder the pinctrl properties.
>   arm64: dts: qcom: msm/apq8x16-*: Drop empty lines in pinctrl states
>   arm64: dts: qcom: msm/apq8x16-*: Reorder some regulator properties
> 
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dts      | 78 +++++++--------
>  .../boot/dts/qcom/msm8916-acer-a1-724.dts     | 15 ++-
>  .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 46 ++++-----
>  .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 34 +++----
>  .../arm64/boot/dts/qcom/msm8916-huawei-g7.dts | 52 ++++------
>  .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 42 ++++----
>  .../boot/dts/qcom/msm8916-longcheer-l8910.dts | 30 +++---
>  arch/arm64/boot/dts/qcom/msm8916-pins.dtsi    | 96 +++++--------------
>  .../qcom/msm8916-samsung-a2015-common.dtsi    | 64 +++++--------
>  .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 11 +--
>  .../boot/dts/qcom/msm8916-samsung-a5u-eur.dts |  5 +-
>  .../qcom/msm8916-samsung-e2015-common.dtsi    |  5 +-
>  .../dts/qcom/msm8916-samsung-grandmax.dts     |  3 +-
>  .../boot/dts/qcom/msm8916-samsung-j5.dts      | 21 ++--
>  .../dts/qcom/msm8916-samsung-serranove.dts    | 62 +++++-------
>  .../dts/qcom/msm8916-wingtech-wt88047.dts     | 35 +++----
>  arch/arm64/boot/dts/qcom/msm8916.dtsi         | 32 +++----
>  17 files changed, 245 insertions(+), 386 deletions(-)
> 
> -- 
> 2.38.1
>