linux-kernel - Re: [PATCH v2 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230119004654.ryti5iwelmnk3otg@synopsys.com>
Date:   Thu, 19 Jan 2023 00:46:56 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Rob Herring <robh@...nel.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Felipe Balbi <balbi@...nel.org>,
        Johan Jonker <jbx6244@...il.com>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains
 property

On Wed, Jan 18, 2023, Rob Herring wrote:
> The Rockchip RK3399 DWC3 node has 'power-domains' property which isn't
> allowed by the schema:
> 
> usb@...00000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> 
> Allow DWC3 nodes to have a power-domains entry. We could instead move
> the power-domains property to the parent wrapper node, but the could be
> an ABI break (Linux shouldn't care). Also, we don't want to encourage
> the pattern of wrapper nodes just to define resources such as clocks,
> resets, power-domains, etc. when not necessary.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> v2:
>  - Allow 2 power domains and explain what they are
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 6d78048c4613..be36956af53b 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -91,6 +91,16 @@ properties:
>          - usb2-phy
>          - usb3-phy
>  
> +  power-domains:
> +    description:
> +      The DWC3 has 2 power-domains. The power management unit (PMU) and
> +      everything else. The PMU is typically always powered and may not have an
> +      entry.
> +    minItems: 1
> +    items:
> +      - description: Core
> +      - description: Power management unit
> +
>    resets:
>      minItems: 1
>  
> -- 
> 2.39.0
> 

Reviewed-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>

Thanks,
Thinh