linux-kernel - Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a958eb22-39c9-4f91-8f72-cd1db7829a3d@app.fastmail.com>
Date:   Thu, 19 Jan 2023 09:57:20 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Brad Larson" <brad@...sando.io>,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org,
        "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
        linux-spi@...r.kernel.org, adrian.hunter@...el.com,
        alcooperx@...il.com, "Andy Shevchenko" <andy.shevchenko@...il.com>,
        blarson@....com, brendan.higgins@...ux.dev,
        "Brian Norris" <briannorris@...omium.org>,
        brijeshkumar.singh@....com,
        "Catalin Marinas" <catalin.marinas@....com>,
        "David Gow" <davidgow@...gle.com>, gsomlo@...il.com,
        gerg@...ux-m68k.org, "Krzysztof Kozlowski" <krzk@...nel.org>,
        krzysztof.kozlowski+dt@...aro.org, "Lee Jones" <lee@...nel.org>,
        "Lee Jones" <lee.jones@...aro.org>,
        "Mark Brown" <broonie@...nel.org>, yamada.masahiro@...ionext.com,
        "Philipp Zabel" <p.zabel@...gutronix.de>, piotrs@...ence.com,
        p.yadav@...com, "Randy Dunlap" <rdunlap@...radead.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Samuel Holland" <samuel@...lland.org>,
        "Serge Semin" <fancer.lancer@...il.com>, skhan@...uxfoundation.org,
        suravee.suthikulpanit@....com, thomas.lendacky@....com,
        "Tony Huang" <tonyhuang.sunplus@...il.com>,
        "Ulf Hansson" <ulf.hansson@...aro.org>, vaishnav.a@...com,
        "Will Deacon" <will@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v9 14/15] mmc: sdhci-cadence: Support mmc hardware reset

On Thu, Jan 19, 2023, at 04:39, Brad Larson wrote:
> 
> +extern unsigned int sdhci_timeout_val;
> +

This declaration should not be in the .c file, and I don't think
there should be a global variable with this overly generic name either.

     Arnd