[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VfurZMfRbqDt7WRY368uu4NM3r2a6SDCogOukBZN5J8yQ@mail.gmail.com>
Date: Thu, 19 Jan 2023 11:58:26 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Brad Larson <blarson@....com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-mmc@...r.kernel.org, linux-spi@...r.kernel.org,
adrian.hunter@...el.com, alcooperx@...il.com, arnd@...db.de,
brad@...sando.io, brendan.higgins@...ux.dev,
briannorris@...omium.org, brijeshkumar.singh@....com,
catalin.marinas@....com, davidgow@...gle.com, gsomlo@...il.com,
gerg@...ux-m68k.org, krzk@...nel.org,
krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
lee.jones@...aro.org, broonie@...nel.org,
yamada.masahiro@...ionext.com, p.zabel@...gutronix.de,
piotrs@...ence.com, p.yadav@...com, rdunlap@...radead.org,
robh+dt@...nel.org, samuel@...lland.org, fancer.lancer@...il.com,
skhan@...uxfoundation.org, suravee.suthikulpanit@....com,
thomas.lendacky@....com, tonyhuang.sunplus@...il.com,
ulf.hansson@...aro.org, vaishnav.a@...com, will@...nel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v9 11/15] spi: dw: Add support for AMD Pensando Elba SoC
On Thu, Jan 19, 2023 at 5:52 AM Brad Larson <blarson@....com> wrote:
>
> The AMD Pensando Elba SoC includes a DW apb_ssi v4 controller
> with device specific chip-select control. The Elba SoC
> provides four chip-selects where the native DW IP supports
> two chip-selects. The Elba DW_SPI instance has two native
> CS signals that are always overridden.
...
> +struct dw_spi_elba {
> + struct regmap *syscon;
> +};
Why can't struct regmap be used directly?
...
> +static void dw_spi_elba_override_cs(struct dw_spi_elba *dwselba, int cs, int enable)
> +{
> + regmap_update_bits(dwselba->syscon, ELBA_SPICS_REG, ELBA_SPICS_MASK(cs),
> + ELBA_SPICS_SET(cs, enable));
> +
Redundant blank line.
> +}
...
> + dev_err(&pdev->dev, "failed to find %s\n", syscon_name);
> + return -ENODEV;
return dev_err_probe();
...
> + dev_err(&pdev->dev, "syscon regmap lookup failed\n");
> + return PTR_ERR(regmap);
Ditto.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists