linux-kernel - Re: [PATCH v6 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167409094385.4360.15863185798758300987.robh@kernel.org>
Date:   Wed, 18 Jan 2023 19:16:53 -0600
From:   Rob Herring <robh@...nel.org>
To:     Mark Yacoub <markyacoub@...omium.org>
Cc:     javierm@...hat.com, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, quic_sbillaka@...cinc.com,
        dianders@...omium.org, swboyd@...omium.org,
        quic_abhinavk@...cinc.com, lucas.demarchi@...el.com,
        konrad.dybcio@...ainline.org, manasi.d.navare@...el.com,
        robdclark@...il.com, marex@...x.de, maxime@...no.tech,
        ankit.k.nautiyal@...el.com, arun.r.murthy@...el.com,
        quic_khsieh@...cinc.com, ashutosh.dixit@...el.com,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        tvrtko.ursulin@...ux.intel.com, bhanuprakash.modem@...el.com,
        jose.souza@...el.com, rodrigo.vivi@...el.com,
        linux-arm-msm@...r.kernel.org, quic_jesszhan@...cinc.com,
        tzimmermann@...e.de, joonas.lahtinen@...ux.intel.com,
        stanislav.lisovskiy@...el.com, swati2.sharma@...el.com,
        ville.syrjala@...ux.intel.com, linux-kernel@...r.kernel.org,
        seanpaul@...omium.org, sean@...rly.run,
        Mark Yacoub <markyacoub@...omiu.org>,
        bjorn.andersson@...aro.org, agross@...nel.org,
        dmitry.baryshkov@...aro.org, matthew.d.roper@...el.com,
        abhinavk@...eaurora.org, intel-gfx@...ts.freedesktop.org,
        daniel@...ll.ch, lyude@...hat.com, hbh25y@...il.com,
        robh+dt@...nel.org, airlied@...il.com, imre.deak@...el.com,
        christophe.jaillet@...adoo.fr, johan+linaro@...nel.org,
        andersson@...nel.org, jani.nikula@...ux.intel.com
Subject: Re: [PATCH v6 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers


On Wed, 18 Jan 2023 19:30:13 +0000, Mark Yacoub wrote:
> From: Sean Paul <seanpaul@...omium.org>
> 
> This patch adds the bindings for the MSM DisplayPort HDCP registers
> which are required to write the HDCP key into the display controller as
> well as the registers to enable HDCP authentication/key
> exchange/encryption.
> 
> We'll use a new compatible string for this since the fields are optional.
> 
> Cc: Rob Herring <robh@...nel.org>
> Cc: Stephen Boyd <swboyd@...omium.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> Signed-off-by: Mark Yacoub <markyacoub@...omiu.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1
> Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2
> Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3
> Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-13-sean@poorly.run #v4
> Link: https://patchwork.freedesktop.org/patch/msgid/20211115202153.117244-1-sean@poorly.run #v4.5
> Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-9-sean@poorly.run #v5
> 
> Changes in v2:
> -Drop register range names (Stephen)
> -Fix yaml errors (Rob)
> Changes in v3:
> -Add new compatible string for dp-hdcp
> -Add descriptions to reg
> -Add minItems/maxItems to reg
> -Make reg depend on the new hdcp compatible string
> Changes in v4:
> -Rebase on Bjorn's multi-dp patchset
> Changes in v4.5:
> -Remove maxItems from reg (Rob)
> -Remove leading zeros in example (Rob)
> Changes in v5:
> -None
> Changes in v6:
> -Rebased: modify minItems instead of adding it as new line.
> 
> ---
>  .../devicetree/bindings/display/msm/dp-controller.yaml    | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.example.dtb: displayport-controller@...0000: reg: [[183042048, 512], [183042560, 512], [183043072, 3072], [183046144, 1024], [183047168, 1024], [183308288, 372], [183373824, 44]] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.example.dtb: edp@...0000: reg: [[183107584, 512], [183108096, 512], [183108608, 3072], [183111680, 1024]] is too short
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230118193015.911074-9-markyacoub@google.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.