linux-kernel - Re: [PATCH V2 1/2] usb: gadget: u_ether: Improve print in gether_setup_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <344ab84a-ab31-33cb-0222-9b75fbd981b2@nvidia.com>
Date:   Thu, 19 Jan 2023 10:14:59 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Subject: Re: [PATCH V2 1/2] usb: gadget: u_ether: Improve print in
 gether_setup_name_default()


On 17/01/2023 15:04, Greg Kroah-Hartman wrote:
> On Mon, Jan 16, 2023 at 03:55:44PM +0000, Jon Hunter wrote:
>> The print in in gether_setup_name_default() does not provide any useful
>> information because a random MAC address will always be generated when
>> calling this function. Rather than removing the print, update the print
>> to show MAC address that is generated which is similar to other ethernet
>> drivers.
>>
>> Finally, given that the strings 'self' and 'host' are static we do not
>> need to pass these strings as an arguments.
>>
>> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
>> ---
>> V1 -> V2: Added this patch
>>
>>   drivers/usb/gadget/function/u_ether.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
>> index 8f12f3f8f6ee..be8e7b448933 100644
>> --- a/drivers/usb/gadget/function/u_ether.c
>> +++ b/drivers/usb/gadget/function/u_ether.c
>> @@ -845,13 +845,13 @@ struct net_device *gether_setup_name_default(const char *netname)
>>   	snprintf(net->name, sizeof(net->name), "%s%%d", netname);
>>   
>>   	eth_random_addr(dev->dev_mac);
>> -	pr_warn("using random %s ethernet address\n", "self");
>> +	pr_warn("using random self ethernet address %pM\n", dev->dev_mac);
> 
> If you are going to fix these up, please use dev_warn() and friends,
> don't use "raw" pr_* calls in a driver.


I had a look at that, but I don't think we can in this case. The 'dev' 
structure you see above is of type 'struct eth_dev' and not 'struct 
device'. In other places in the driver where dev_warn is used the device 
structure comes from the 'struct usb_gadget' but FWICT this is not 
initialised in the above function.

Jon

-- 
nvpublic