linux-kernel - Re: [PATCH 3/3] ASoC: google: dt-bindings: sc7280: Add #sound-dai-cells property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <452b332a-d796-119c-e80a-e68914f46702@kernel.org>
Date:   Thu, 19 Jan 2023 13:17:12 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
        agross@...nel.org, andersson@...nel.org, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org, quic_plai@...cinc.com,
        bgoswami@...cinc.com, perex@...ex.cz, tiwai@...e.com,
        srinivas.kandagatla@...aro.org, quic_rohkumar@...cinc.com,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, swboyd@...omium.org,
        judyhsiao@...omium.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] ASoC: google: dt-bindings: sc7280: Add
 #sound-dai-cells property

On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
> Update sc7280 machine driver bindings with #sound-dai-cells property.
> This is to fix dtbs_check errors.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
> Tested-by: Ratna Deepthi Kudaravalli <quic_rkudarv@...cinc.com>
> ---
>  Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> index ccf1b1d..be5c60a 100644
> --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> @@ -35,6 +35,9 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  "#sound-dai-cells":
> +    const: 0

That's not correct property for the sound card. Does the sound card
exposes DAIs? Who uses these?

> +
>  patternProperties:
>    "^dai-link@[0-9a-f]$":
>      description:

Best regards,
Krzysztof