linux-kernel - Re: [PATCH v2] scsi: ufs: core: fix devfreq deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167408762166.3511288.15577656498672472733.b4-ty@oracle.com>
Date:   Wed, 18 Jan 2023 19:21:28 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Johan Hovold <johan+linaro@...nel.org>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bart Van Assche <bvanassche@....org>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Can Guo <quic_cang@...cinc.com>,
        Andrew Halaney <ahalaney@...hat.com>
Subject: Re: [PATCH v2] scsi: ufs: core: fix devfreq deadlocks

On Mon, 16 Jan 2023 17:12:01 +0100, Johan Hovold wrote:

> There is a lock inversion and rwsem read-lock recursion in the devfreq
> target callback which can lead to deadlocks.
> 
> Specifically, ufshcd_devfreq_scale() already holds a clk_scaling_lock
> read lock when toggling the write booster, which involves taking the
> dev_cmd mutex before taking another clk_scaling_lock read lock.
> 
> [...]

Applied to 6.2/scsi-fixes, thanks!

[1/1] scsi: ufs: core: fix devfreq deadlocks
      https://git.kernel.org/mkp/scsi/c/ba81043753ff

-- 
Martin K. Petersen	Oracle Linux Engineering