linux-kernel - Re: [PATCH] clocksource/drivers/arm_arch_timer: Update sched_clock when non-boot CPUs need counter workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <86c8b6b630954e63999b58de9d820408@mailboxsrv05.LongCheer.net>
Date:   Thu, 19 Jan 2023 13:28:19 +0000
From:   王法杰 <wangfajie@...gcheer.com>
To:     Marc Zyngier <maz@...nel.org>
CC:     "daniel.lezcano@...nel.org" <daniel.lezcano@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "quic_ylal@...cinc.com" <quic_ylal@...cinc.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "will@...nel.org" <will@...nel.org>,
        刘仁旺 <liurenwang@...gcheer.com>,
        张辉 <zhanghui5@...gcheer.com>,
        "liangke1@...omi.com" <liangke1@...omi.com>,
        沈兵 <ShenBing@...gcheer.com>,
        刘琦 <liuqi405@...oud.com>
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Update sched_clock
 when non-boot CPUs need counter workaround

Hi Marc Zyngier

We found the APPS Crash issue on MTBF test.
Brief crash information, APPS Crash - Kernel BUG at /sched/walt/sched_avg.c:281! in sched_update_nr_prod flow

[Test equipment]
1. Number of phone:  200 pcs
2. CPU info of phone:  CPU architecture with Quad Cortex-A73 and Quad Cortex-A53

[Preset conditions]
1. Android 13 with kernel 5.15
2. Install application of top 20
3. Connected to Wi-Fi
4. Connect the adapter to charge the phone
5. Test duration 48 hours

[Expected results]
0 crash happened.

[Test results without [PATCH] clocksource/drivers/arm_arch_timer: Update sched_clock when non-boot CPUs need counter workaround ]
1. First round of test, found 3 phones with APPS Crash issue on /sched/walt/sched_avg.c:281! in sched_update_nr_prod flow
2. Second round of test, found 7 phones with APP Crash issue on /sched/walt/sched_avg.c:281! in sched_update_nr_prod flow

[Test results with [PATCH] clocksource/drivers/arm_arch_timer: Update sched_clock when non-boot CPUs need counter workaround ] 
1. First round of test, 0 crash happened.
2. Second round of test, 0 crash happened.

Tested-by: wangfajie <wangfajie@...gcheer.com>
Tested-by: liurenwang <liurenwang@...gcheer.com>
Tested-by: zhanghui <zhanghui5@...gcheer.com>
Tested-by: liangke <liangke1@...omi.com>

So we think the PATCH is working and it can fix APPS crash issue. Many thanks your time.

Best regards!
Wangfajie

-----邮件原件-----
发件人: Marc Zyngier [mailto:maz@...nel.org] 
发送时间: 2023年1月19日 17:52
收件人: 刘琦 <liuqi405@...oud.com>
抄送: daniel.lezcano@...nel.org; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; mark.rutland@....com; quic_ylal@...cinc.com; stable@...r.kernel.org; will@...nel.org; 王法杰 <wangfajie@...gcheer.com>; 刘仁旺 <liurenwang@...gcheer.com>; 张辉 <zhanghui5@...gcheer.com>; liangke1@...omi.com
主题: Re: [PATCH] clocksource/drivers/arm_arch_timer: Update sched_clock when non-boot CPUs need counter workaround

On 2023-01-19 07:59, 刘琦 wrote:
> [Test Report]
> Result: Test Pass
> 
> A total of two rounds of pending testing
>      a. The first round of hanging test
>           Number of machines: 200
>           Hanging test duration: 48h
>           Hanging test results: no walt crash problem
>      b. The second round of hanging test
>           Number of machines: 200
>           Hanging test duration: 72h
>           Hanging test results: no walt crash problem
> 
> Tested-by: wangfajie <wangfajie@...gcheer.com>
> Tested-by: liurenwang <liurenwang@...gcheer.com>
> Tested-by: zhanghui <zhanghui5@...gcheer.com>
> Tested-by: liangke <liangke1@...omi.com>

Thanks for this.

The only issue here is that that you don't explain what you tested, nor how you tested it.

It is also a patch that has known defects (you just have to read the thread for the details)... This makes this testing, no matter how thorough it is, rather ineffective.

         M.
--
Jazz is not dead. It just smells funny...