linux-kernel - Re: [PATCH 2/2] clk: mediatek: add MT7981 clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8fafc86-40fe-c0ef-1310-b4e284e14609@collabora.com>
Date:   Thu, 19 Jan 2023 15:29:22 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Daniel Golle <daniel@...rotopia.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Cc:     Chen-Yu Tsai <wenst@...omium.org>,
        Miles Chen <miles.chen@...iatek.com>,
        Edward-JW Yang <edward-jw.yang@...iatek.com>,
        Johnson Wang <johnson.wang@...iatek.com>,
        Fabien Parent <fparent@...libre.com>,
        Chun-Jie Chen <chun-jie.chen@...iatek.com>,
        Sam Shih <sam.shih@...iatek.com>,
        Jianhui Zhao <zhaojh329@...il.com>
Subject: Re: [PATCH 2/2] clk: mediatek: add MT7981 clock support

Il 19/01/23 15:12, Daniel Golle ha scritto:
> Add MT7986 clock support, include topckgen, apmixedsys, infracfg and
> ethernet subsystem clocks.
> 
> The drivers are based on clk-mt7981.c which can be found in MediaTek's
> SDK sources. To be fit for upstream inclusion the driver has been split
> into clock domains and the infracfg part has been significantly
> de-bloated by removing all the 1:1 factors (aliases).
> 
> Signed-off-by: Jianhui Zhao <zhaojh329@...il.com>
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>   drivers/clk/mediatek/Kconfig               |  17 +
>   drivers/clk/mediatek/Makefile              |   4 +
>   drivers/clk/mediatek/clk-mt7981-apmixed.c  | 103 +++++
>   drivers/clk/mediatek/clk-mt7981-eth.c      | 138 +++++++
>   drivers/clk/mediatek/clk-mt7981-infracfg.c | 236 +++++++++++
>   drivers/clk/mediatek/clk-mt7981-topckgen.c | 431 +++++++++++++++++++++
>   include/dt-bindings/clock/mt7981-clk.h     | 215 ++++++++++

dt-bindings go in a different commit; also, please follow binding rules for
filenames... mt7981-clk.h -> mediatek,mt7981-clk.h

>   7 files changed, 1144 insertions(+)
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-apmixed.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-eth.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-infracfg.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-topckgen.c
>   create mode 100644 include/dt-bindings/clock/mt7981-clk.h
> 

Moreover, I have pushed a pretty big cleanup series, which would reduce a bit
the size of the drivers that you're trying to introduce, and which is well
tested and reviewed: can you please rebase this on top of [1]?

Thanks!

[1]: https://patchwork.kernel.org/project/linux-mediatek/list/?series=711734

Regards,
Angelo