linux-kernel - Re: [RFC PATCH v2 09/31] kvx: Add build infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jan 2023 16:01:11 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Jules Maselbas" <jmaselbas@...ray.eu>
Cc:     "Yann Sionneau" <ysionneau@...ray.eu>,
        "Jonathan Corbet" <corbet@....net>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Marc Zyngier" <maz@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Will Deacon" <will@...nel.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Boqun Feng" <boqun.feng@...il.com>,
        "Mark Rutland" <mark.rutland@....com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Kees Cook" <keescook@...omium.org>,
        "Oleg Nesterov" <oleg@...hat.com>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Waiman Long" <longman@...hat.com>,
        "Aneesh Kumar" <aneesh.kumar@...ux.ibm.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Nicholas Piggin" <npiggin@...il.com>,
        "Paul Moore" <paul@...l-moore.com>,
        "Eric Paris" <eparis@...hat.com>,
        "Christian Brauner" <brauner@...nel.org>,
        "Paul Walmsley" <paul.walmsley@...ive.com>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Albert Ou" <aou@...s.berkeley.edu>,
        "Guillaume Thouvenin" <gthouvenin@...ray.eu>,
        "Clement Leger" <clement@...ment-leger.fr>,
        "Vincent Chardon" <vincent.chardon@...ys-design.com>,
        Marc Poulhiès <dkm@...aplop.net>,
        "Julian Vetter" <jvetter@...ray.eu>,
        "Samuel Jones" <sjones@...ray.eu>,
        "Ashley Lesdalons" <alesdalons@...ray.eu>,
        "Thomas Costis" <tcostis@...ray.eu>,
        "Marius Gligor" <mgligor@...ray.eu>,
        "Jonathan Borne" <jborne@...ray.eu>,
        "Julien Villette" <jvillette@...ray.eu>,
        "Luc Michel" <lmichel@...ray.eu>,
        "Louis Morhet" <lmorhet@...ray.eu>,
        "Julien Hascoet" <jhascoet@...ray.eu>,
        "Jean-Christophe Pince" <jcpince@...il.com>,
        "Guillaume Missonnier" <gmissonnier@...ray.eu>,
        "Alex Michon" <amichon@...ray.eu>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "WANG Xuerui" <git@...0n.name>,
        "Shaokun Zhang" <zhangshaokun@...ilicon.com>,
        "John Garry" <john.garry@...wei.com>,
        "Guangbin Huang" <huangguangbin2@...wei.com>,
        "Bharat Bhushan" <bbhushan2@...vell.com>,
        "Bibo Mao" <maobibo@...ngson.cn>,
        "Atish Patra" <atishp@...shpatra.org>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        "Qi Liu" <liuqi115@...wei.com>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Mark Brown" <broonie@...nel.org>,
        "Janosch Frank" <frankja@...ux.ibm.com>,
        "Alexey Dobriyan" <adobriyan@...il.com>,
        "Benjamin Mugnier" <mugnier.benjamin@...il.com>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-mm@...ck.org,
        Linux-Arch <linux-arch@...r.kernel.org>, linux-audit@...hat.com,
        linux-riscv@...ts.infradead.org, bpf@...r.kernel.org
Subject: Re: [RFC PATCH v2 09/31] kvx: Add build infrastructure

On Fri, Jan 20, 2023, at 15:53, Jules Maselbas wrote:
> On Fri, Jan 20, 2023 at 03:39:22PM +0100, Arnd Bergmann wrote:
>> On Fri, Jan 20, 2023, at 15:09, Yann Sionneau wrote:
>> >      - Fix clean target raising an error from gcc (LIBGCC)
>> 
>> I had not noticed this on v1 but:
>> 
>> > +# Link with libgcc to get __div* builtins.
>> > +LIBGCC	:= $(shell $(CC) $(DEFAULT_OPTS) --print-libgcc-file-name)
>> 
>> It's better to copy the bits of libgcc that you actually need
>> than to include the whole thing. The kernel is in a weird
> It was initialy using KCONFIG_CFLAGS which do not contains valid options
> when invoking the clean target.
>
> I am not exactly sure what's needed by gcc for --print-libgcc-file-name,
> my guess is that only the -march option matters, I will double check
> internally with compiler peoples.
>
>> state that is neither freestanding nor the normal libc based
>> environment, so we generally want full control over what is
>> used. This is particularly important for 32-bit architectures
>> that do not want the 64-bit division, but there are probably
>> enough other cases as well.

To clarify: I meant you should not include libgcc.a at all but
add the minimum set of required files as arch/kvx/lib/*.S.

     Arnd