linux-kernel - RE: [PATCH 1/2] virtio-rng: implement entropy leak feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW5PR84MB18426587FD27BB152D621BABABC59@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Fri, 20 Jan 2023 15:07:08 +0000
From:   "Elliott, Robert (Servers)" <elliott@....com>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        Babis Chalios <bchalios@...zon.es>
CC:     Olivia Mackall <olivia@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Jason Wang <jasowang@...hat.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "amit@...nel.org" <amit@...nel.org>,
        "graf@...zon.de" <graf@...zon.de>,
        "Jason@...c4.com" <Jason@...c4.com>,
        "xmarcalx@...zon.co.uk" <xmarcalx@...zon.co.uk>
Subject: RE: [PATCH 1/2] virtio-rng: implement entropy leak feature

> > +#include "asm-generic/errno.h"
> 
> Why are you pulling this in?
> If you really need errno the thing to include
> is linux/errno.h
> 
> checkpatch has a rule to catch such cases:
> 
> # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
> # itself <asm/foo.h> (uses RAW line)

It's only looking for asm, not variations like asm-generic.