linux-kernel - Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a1ae8e9-ab0e-038a-084f-240f73489010@linuxfoundation.org>
Date:   Fri, 20 Jan 2023 09:15:17 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     sedat.dilek@...il.com, Huang Rui <ray.huang@....com>
Cc:     Doug Smythies <dsmythies@...us.net>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Meng, Li (Jassmine)" <Li.Meng@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: amd-pstate: Don't delete source files via
 Makefile

On 1/20/23 09:11, Sedat Dilek wrote:
> On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@....com> wrote:
>>
>> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
>>> Revert the portion of a recent Makefile change that incorrectly
>>> deletes source files when doing "make clean".

Ooo. That is bad.

>>>
>>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>>> Reported-by: Sedat Dilek <sedat.dilek@...il.com>
>>> Tested-by: Sedat Dilek <sedat.dilek@...il.com>
>>> Signed-off-by: Doug Smythies <dsmythies@...us.net>
>>
>> (+ Shuah and linux-kselftest mailing list)
>>
>> Thanks for fix!
>>
>> Acked-by: Huang Rui <ray.huang@....com>
>>
> 
> [ I already replied - but with these important CCs ]
> 
> Hi Doug,
> 
> Thanks for the patch!
> 
> Small nit, I saw this with:

What did you see and should that be fixed as well.

> 
> $ make -C tools/ clean
> 
> Otherwise:
> 
> Reviewed-by: Sedat Dilek <sedat.dilek@...il.com>
> 

Send me the revised patch with all the right CCs and I will pull
this right away.

thanks,
-- Shuah