linux-kernel - Re: [PATCH v2] arm64: defconfig: Enable HDA INTEL config for ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbeff3da-e03b-aa82-1a53-d92f95b63770@linaro.org>
Date:   Fri, 20 Jan 2023 18:00:25 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Mohan Kumar D <mkumard@...dia.com>, will@...nel.org,
        dmitry.baryshkov@...aro.org, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        treding@...dia.com, jonathanh@...dia.com
Subject: Re: [PATCH v2] arm64: defconfig: Enable HDA INTEL config for ARM64

On 20/01/2023 17:56, Catalin Marinas wrote:
> On Fri, Jan 20, 2023 at 07:20:01AM +0100, Krzysztof Kozlowski wrote:
>> On 20/01/2023 06:48, Mohan Kumar D wrote:
>>> On 18-01-2023 18:06, Krzysztof Kozlowski wrote:
>>>> External email: Use caution opening links or attachments
>>>> On 18/01/2023 12:46, Mohan Kumar D wrote:
>>>>> On 18-01-2023 13:04, Krzysztof Kozlowski wrote:
>>>>>> External email: Use caution opening links or attachments
>>>>>> On 17/01/2023 19:16, Mohan Kumar wrote:
>>>>>>> Enable CONFIG_SND_HDA_INTEL for NVIDIA PCI based graphics sound card for
>>>>>>> ARM64 based platforms as Intel PCI driver was used for registering the
>>>>>>> sound card.
>>>>>> It's not a part of SoC, not a common device used during debugging or
>>>>>> development, so I don't think it is reasonable to enable it. We do not
>>>>>> enable driver just because someone uses them. Otherwise please clarify
>>>>>> which board has this device embedded (not pluggable by user, but embedded).
>>>>> This change is required for enabling HDA sound registration for Nvidia
>>>>> discrete GPU cards based on PCI and pluggable to Nvidia Jetson Platforms.
>>>> You can plug anything to PCI slot and we do not enable every such PCI
>>>> adapter.
>>> Without this config enabled, the Intel hda audio driver won't be built 
>>> and dGPU won't be able to register sound card. Do you have any 
>>> suggestion here?
>>
>> Without hundreds of other drivers they also won't be built and won't be
>> usable. Anyway, this is just defconfig, so it does not matter. You can
>> always enable it in your setup, why is this a problem?
>>
>> Again, we do not enable drivers for every PCI card.
> 
> I don't think we have any set rules for what goes in a defconfig. If one
> has a real use-case, we tend to enable stuff in defconfig, especially if
> it's a module.

There will be always an use case for every PCI and USB card. It's not
related to storage or networking which could justify device bringup
(rootfs). It's really not needed for any board operation. defconfig is
not for marketing products but for our development and reference platforms.

The only argument behind this change is "I have a PCI card and I want it
in defconfig", but why it has to be in defconfig in the first place?
There is no reason. This is not distro...

Best regards,
Krzysztof