linux-kernel - Re: [patchv2 1/3] VT: Add height parameter to con_font

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8ldFjz7d6/CMA0w@kroah.com>
Date:   Thu, 19 Jan 2023 16:09:10 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:     Jiri Slaby <jirislaby@...nel.org>, kbd@...ts.altlinux.org,
        linux-kernel@...r.kernel.org
Subject: Re: [patchv2 1/3] VT: Add height parameter to con_font_get/set consw
 operations

On Sun, Dec 18, 2022 at 01:32:10AM +0100, Samuel Thibault wrote:
> The current con_font_get/set API currently hardcodes a 32-pixel-tall
> limitation, which only dates from the old VGA hardware which could not
> handle taller fonts than that.
> 
> This change just adds a vpitch parameter to release this
> constraint. Drivers which do not support vpitch != 32 can just return
> EINVAL when it is not 32, font loading tools will revert to trying 32
> and succeed.
> 
> This change makes the fbcon driver consider vpitch appropriately, thus
> making it able to load large fonts.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>
> 
> ---
> V1 -> V2: Drop (bogus) sisusb_con.c change, it is being phased out
> 
> Index: linux-6.0/drivers/tty/vt/vt.c

6.0 was really old when you sent this, and because of that:

> Index: linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> ===================================================================

This file is not even in the tree anymore.

Can you rebase this against 6.2-rc4 and resubmit it so that I can apply
it?  As-is, it will not apply at all :(

thanks,

greg k-h