[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f0c5e40e-e59d-152d-31f1-1ad3da0a6d34@kernel.org>
Date: Thu, 19 Jan 2023 13:13:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
agross@...nel.org, andersson@...nel.org, lgirdwood@...il.com,
broonie@...nel.org, robh+dt@...nel.org, quic_plai@...cinc.com,
bgoswami@...cinc.com, perex@...ex.cz, tiwai@...e.com,
srinivas.kandagatla@...aro.org, quic_rohkumar@...cinc.com,
linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, swboyd@...omium.org,
judyhsiao@...omium.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/3] ASoC: google: dt-bindings: sc7280: Add platform
property
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
> Update sc7280 machine driver bindings with platform property for
> supporting ADSP based platform's DAI links.
Subject:
ASoC: dt-bindings: google,sc7280-herobrine:
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
> Tested-by: Ratna Deepthi Kudaravalli <quic_rkudarv@...cinc.com>
This tested tag is a bit unusual. How were they tested? If
dt_bindings_check why this is not the same person as you (submitter)?
> ---
> .../devicetree/bindings/sound/google,sc7280-herobrine.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> index 869b403..ccf1b1d 100644
> --- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> @@ -75,6 +75,17 @@ patternProperties:
>
> additionalProperties: false
>
> + platform:
> + description: Holds subnode which indicates platform dai.
Neither commit msg nor this here explains why do you need it and what it
really represents. Basically description repeats "platform" name of
property - there is no single new information.
> + type: object
> + properties:
> + sound-dai: true
maxItems
> +
> + required:
> + - sound-dai
> +
> + additionalProperties: false
> +
> required:
> - link-name
> - cpu
Best regards,
Krzysztof
Powered by blists - more mailing lists