lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y8kl0YZwMO3nkaly@sirena.org.uk>
Date:   Thu, 19 Jan 2023 11:13:21 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Arnd Bergmann <arnd@...nel.org>, Tony Lindgren <tony@...mide.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jerome Neanne <jneanne@...libre.com>,
        Axel Lin <axel.lin@...ics.com>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] regulator: tps65219: fix Wextra warning

On Thu, Jan 19, 2023 at 09:07:38AM +0100, Arnd Bergmann wrote:

> It looks like you merged another workaround from Randy Dunlap now as
> commit 2bbba115c3c9 ("regulator: tps65219: use IS_ERR() to detect an error
> pointer"), but I think that one is just as wrong as the one I submitted:
> the 'rdev' variable still remains uninitialized, and checking its value
> after it has already been used is not helpful.

Right, that's just changing the way the result is parsed, it's
nothing to do with making sure things are initialised.  It's just
a coccinelle style thing.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ