linux-kernel - Re: [PATCH 1/4] dt-bindings: regulator: Describe Maxim MAX20411

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <862603f6-a69d-f039-4039-70320da39962@linaro.org>
Date:   Fri, 20 Jan 2023 09:21:39 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bjorn Andersson <quic_bjorande@...cinc.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: regulator: Describe Maxim MAX20411

On 19/01/2023 22:47, Bjorn Andersson wrote:
> Add binding for the Maxim MAX20411 step-down DC-DC converter.
> 

Subject prefix should probably be "regulator: dt-bindings: ", as per
Mark's requests.

> Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> ---
>  .../bindings/regulator/maxim,max20411.yaml    | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max20411.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max20411.yaml b/Documentation/devicetree/bindings/regulator/maxim,max20411.yaml
> new file mode 100644
> index 000000000000..3d1ba6139370
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max20411.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/maxim,max20411.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX20411 Step-Down DC-DC Converter
> +
> +maintainers:
> +  - Bjorn Andersson <andersson@...nel.org>
> +
> +description:
> +  The MAX20411 is a high-efficiency, DC-DC step-down converter. It provides
> +  configurable output voltage in the range of 0.5V to 1.275V, configurable over
> +  I2C.
> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    const: maxim,max20411
> +
> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    maxItems: 1

Drop maxItems, provided by gpio-consumer-common.

> +    description: GPIO connected to the EN pin, active high
> +

With two above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof