linux-kernel - Re: [PATCH 01/12] crypto: axis - do not DMA to ahash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8paPhBZqzipaMEL@gondor.apana.org.au>
Date:   Fri, 20 Jan 2023 17:09:18 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     davem@...emloft.net, jesper.nilsson@...s.com,
        lars.persson@...s.com, kernel@...s.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lars Persson <larper@...s.com>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 01/12] crypto: axis - do not DMA to ahash_request.result

On Tue, Jan 10, 2023 at 02:50:31PM +0100, Vincent Whitchurch wrote:
>
> @@ -2216,6 +2220,14 @@ static void artpec6_crypto_complete_aead(struct crypto_async_request *req)
>  
>  static void artpec6_crypto_complete_hash(struct crypto_async_request *req)
>  {
> +	struct ahash_request *areq = container_of(req, struct ahash_request, base);
> +	struct artpec6_hash_request_context *ctx = ahash_request_ctx(areq);
> +	struct crypto_ahash *ahash = crypto_ahash_reqtfm(areq);
> +	size_t digestsize = crypto_ahash_digestsize(ahash);
> +
> +	if (ctx->hash_flags & HASH_FLAG_FINALIZED)
> +		memcpy(areq->result, ctx->digeststate, digestsize);
> +

I was just looking through the driver and digeststate does not
appear to be aligned to the DMA cacheline, should it be?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt