linux-kernel - Re: [PATCH net] net: dsa: microchip: fix probe of I2C-connected KSZ8563

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55b34928-e5b0-7ab7-fa40-5ae73d05a269@pengutronix.de>
Date:   Fri, 20 Jan 2023 11:42:09 +0100
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Arun.Ramadoss@...rochip.com, olteanv@...il.com,
        UNGLinuxDriver@...rochip.com, andrew@...n.ch, f.fainelli@...il.com,
        kuba@...nel.org, Woojung.Huh@...rochip.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, pabeni@...hat.com, ore@...gutronix.de,
        edumazet@...gle.com
Subject: Re: [PATCH net] net: dsa: microchip: fix probe of I2C-connected
 KSZ8563

On 20.01.23 11:38, Arun.Ramadoss@...rochip.com wrote:
> On Fri, 2023-01-20 at 08:57 +0100, Ahmad Fatoum wrote:
>>> In this commit, there is no KSZ8563 member in struct
>>> ksz_switch_chips.
>>> Whether the fixes should be to this commit "net: dsa: microchip:
>>> add
>>> separate struct ksz_chip_data for KSZ8563" where the member is
>>> introduced.
>>
>> I disagree. eee16b147121 introduced the check that made my device
>> not probe anymore, so that's what's referenced in Fixes:. Commit
>> b44908095612 should have had a Fixes: pointing at eee16b147121
>> as well, so users don't miss it. But if they miss it, they
>> will notice this at build-time anyway.
> 
> The KSZ9893, KSZ9563 and KSZ8563 all has the same chip id 0x00989300.
> They belong to 3 port switch family. Differentiation is done based on
> 0x1F register. In the commit eee16b147121, there is no differentiation
> based on 0x1F, device is selected based on chip id, all the three chips
> will be identified as ksz9893 only. After the commit b44908095612,
> KSZ8563 chips is identified based on 0x1F register.

Thanks for the elaboration. I see it now. I will send a v2
with revised commit messages and Fixes:. Should I include
your Reviewed-by: with the commit message rewritten?

Cheers,
Ahmad

> 
>>
>> Cheers,
>> Ahmad
>>
>>>
>>>> chip
>>>> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
>>>> ---
>>>>  drivers/net/dsa/microchip/ksz9477_i2c.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c
>>>> b/drivers/net/dsa/microchip/ksz9477_i2c.c
>>>> index c1a633ca1e6d..e315f669ec06 100644
>>>> --- a/drivers/net/dsa/microchip/ksz9477_i2c.c
>>>> +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
>>>> @@ -104,7 +104,7 @@ static const struct of_device_id
>>>> ksz9477_dt_ids[]
>>>> = {
>>>>         },
>>>>         {
>>>>                 .compatible = "microchip,ksz8563",
>>>> -               .data = &ksz_switch_chips[KSZ9893]
>>>> +               .data = &ksz_switch_chips[KSZ8563]
>>>>         },
>>>>         {
>>>>                 .compatible = "microchip,ksz9567",
>>>> --
>>>> 2.30.2
>>>>
>>
>> --
>> Pengutronix
>> e.K.                           |                             |
>> Steuerwalder Str. 21                       | 
>> http://www.pengutronix.de/e/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-
>> 0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-
>> 5555 |
>>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |