linux-kernel - Re: [PATCH] drm/tegra: sor: Remove redundant error logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y8p1NbUH16avUefO@ubun2204.myguest.virtualbox.org>
Date:   Fri, 20 Jan 2023 16:34:21 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Jonathan Hunter <jonathanh@...dia.com>,
        dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Saurabh Singh Sengar <ssengar@...rosoft.com>,
        Praveen Kumar <kumarpraveen@...ux.microsoft.com>
Subject: Re: [PATCH] drm/tegra: sor: Remove redundant error logging

On Tue, Dec 20, 2022 at 02:27:50AM +0530, Deepak R Varma wrote:
> On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote:
> 
> Hello,
> May I please request a review and feedback on this patch proposal?
> 
> Also, I was able to build the changes for ARM arch verified using modinfo
> tegr-drm.ko command.

Hello,
I am waiting on a feedback on this patch proposal. Do I need to resend it to get
maintainer attention? Please advise.

Thank you,
./drv

> 
> 
> Thank you,
> ./drv
> 
> 
> > A call to platform_get_irq() already prints an error on failure within
> > its own implementation. So printing another error based on its return
> > value in the caller is redundant and should be removed. The clean up
> > also makes if condition block braces unnecessary. Remove that as well.
> >
> > Issue identified using platform_get_irq.cocci coccicheck script.
> >
> > Signed-off-by: Deepak R Varma <drv@...lo.com>
> > ---
> > Please note: I was not able to build this driver since I did not find the
> > DRM_TEGRA option in menu config. All dependencies listed in the KConfig are
> > enabled, however, I was still not able to find the DRM_TEGRA module in the
> > Graphics-Drivers list. Since the proposed change is known, minor and obvious, I
> > am sending in this patch without build testing.
> >
> > Any advise on how to enable the DRM_TEGRA module in menuconfig selection list
> > will be helpful. Thank you.
> >
> >
> >  drivers/gpu/drm/tegra/sor.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> > index 8af632740673..ceaebd33408d 100644
> > --- a/drivers/gpu/drm/tegra/sor.c
> > +++ b/drivers/gpu/drm/tegra/sor.c
> > @@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
> >  	}
> >
> >  	err = platform_get_irq(pdev, 0);
> > -	if (err < 0) {
> > -		dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
> > +	if (err < 0)
> >  		goto remove;
> > -	}
> >
> >  	sor->irq = err;
> >
> > --
> > 2.34.1
> >