[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y8qFPBEYJ1gH/Ycv@sirena.org.uk>
Date: Fri, 20 Jan 2023 12:12:44 +0000
From: Mark Brown <broonie@...nel.org>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org,
Christophe Leroy <christophe.leroy@...roup.eu>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 2/3] ASoC: codecs: Add support for the Renesas
IDT821034 codec
On Fri, Jan 20, 2023 at 10:50:35AM +0100, Herve Codina wrote:
> +static int idt821034_kctrl_gain_put(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct soc_mixer_control *mc = (struct soc_mixer_control *)kcontrol->private_value;
> + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
> + struct idt821034 *idt821034 = snd_soc_component_get_drvdata(component);
> + struct idt821034_amp *amp;
> +
> + amp->gain = val;
> + ret = 0;
> +end:
> + mutex_unlock(&idt821034->mutex);
> + return ret;
_put() methods should return 1 if the value changed to generate
events - if you use the mixer-test selftest it'll spot this and
other issues for you.
Otherwise this looks fine.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists