linux-kernel - Re: [PATCH] usb: mtu3: fix the failure of qmu stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d277d1e-f06a-07ad-f2c3-f910880a40d7@collabora.com>
Date:   Fri, 20 Jan 2023 14:06:28 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Eddie Hung <eddie.hung@...iatek.com>,
        Min Guo <min.guo@...iatek.com>
Subject: Re: [PATCH] usb: mtu3: fix the failure of qmu stop

Il 19/01/23 04:33, Chunfeng Yun ha scritto:
> This happens when do stress test of uvc stream on/off which will
> enable/disable endpoints. uvc has four tx requests, and may disable
> endpoint between queue tx requests as following:
>      enable ep --> start qmu
>      queue tx request0
>      queue tx request1
>      queue tx request2 --> resume qmu
>      disable ep --> stop qmu may fail [1]
>      queue tx request3 --> will resume qmu, may cause qmu can't work
>                            when enable ep next time [2]
> 
> [1]: when the tx fifo has some data to transmit, and
>      try to stop qmu (stop ep) meanwhile resume qmu (queue tx request),
>      it may cause stop qmu timeout, then can be fixed by flushing fifo
>      when stop qmu.
> [2]: it resumes qmu again, shall stop qmu again.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> Reported-by: Min Guo <min.guo@...iatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>