linux-kernel - Re: [PATCH] perf/x86: KVM: Disable vPMU support on hybrid CPUs (host PMUs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dec071d-c010-cd89-9e58-d643e71e775c@linux.intel.com>
Date:   Fri, 20 Jan 2023 09:39:41 -0500
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Cc:     Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jianfeng Gao <jianfeng.gao@...el.com>,
        Andrew Cooper <Andrew.Cooper3@...rix.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf/x86: KVM: Disable vPMU support on hybrid CPUs (host
 PMUs)



On 2023-01-19 7:40 p.m., Sean Christopherson wrote:
> Disable KVM support for virtualizing PMUs on hosts with hybrid PMUs until
> KVM gains a sane way to enumeration the hybrid vPMU to userspace and/or
> gains a mechanism to let userspace opt-in to the dangers of exposing a
> hybrid vPMU to KVM guests.
> 
> Virtualizing a hybrid PMU, or at least part of a hybrid PMU, is possible,
> but it requires userspace to pin vCPUs to pCPUs to prevent migrating a
> vCPU between a big core and a little core, requires the VMM to accurately
> enumerate the topology to the guest (if exposing a hybrid CPU to the
> guest), and also requires the VMM to accurately enumerate the vPMU
> capabilities to the guest.

Current kernel only return the common counters to KVM, which is
available on both e-core and p-core. In theory, there should be no
problem with the migration between cores. You don't have to pin vCPU.
The only problem is that you probably can only use the architecture events.

There is nothing wrong for the information provided by the kernel. I
think it should be a KVM issue (my guess is the CPUID enumeration.) we
should fix rather than simply disable the PMU for entire hybrid machines.

Thanks,
Kan
> 
> The last point is especially problematic, as KVM doesn't control which
> pCPU it runs on when enumerating KVM's vPMU capabilities to userspace.
> For now, simply disable vPMU support on hybrid CPUs to avoid inducing
> seemingly random #GPs in guests.
> 
> Reported-by: Jianfeng Gao <jianfeng.gao@...el.com>
> Cc: stable@...r.kernel.org
> Cc: Andrew Cooper <Andrew.Cooper3@...rix.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Link: https://lore.kernel.org/all/20220818181530.2355034-1-kan.liang@linux.intel.com
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
> 
> Lightly tested as I don't have hybrid hardware.  For the record, I'm not
> against supporting hybrid vPMUs in KVM, but it needs to be a dedicated
> effort and not implicitly rely on userspace to do the right thing (or get
> lucky).
> 
>  arch/x86/events/core.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
> index 85a63a41c471..a67667c41cc8 100644
> --- a/arch/x86/events/core.c
> +++ b/arch/x86/events/core.c
> @@ -2974,17 +2974,18 @@ unsigned long perf_misc_flags(struct pt_regs *regs)
>  
>  void perf_get_x86_pmu_capability(struct x86_pmu_capability *cap)
>  {
> -	if (!x86_pmu_initialized()) {
> +	/*
> +	 * Hybrid PMUs don't play nice with virtualization unless userspace
> +	 * pins vCPUs _and_ can enumerate accurate information to the guest.
> +	 * Disable vPMU support for hybrid PMUs until KVM gains a way to let
> +	 * userspace opt into the dangers of hybrid vPMUs.
> +	 */
> +	if (!x86_pmu_initialized() || is_hybrid()) {
>  		memset(cap, 0, sizeof(*cap));
>  		return;
>  	}
>  
>  	cap->version		= x86_pmu.version;
> -	/*
> -	 * KVM doesn't support the hybrid PMU yet.
> -	 * Return the common value in global x86_pmu,
> -	 * which available for all cores.
> -	 */
>  	cap->num_counters_gp	= x86_pmu.num_counters;
>  	cap->num_counters_fixed	= x86_pmu.num_counters_fixed;
>  	cap->bit_width_gp	= x86_pmu.cntval_bits;
> 
> base-commit: de60733246ff4545a0483140c1f21426b8d7cb7f