linux-kernel - Re: [PATCH v3 1/1] scsi: ufs: Add hibernation callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202301211209.zKDppcLI-lkp@intel.com>
Date:   Sat, 21 Jan 2023 12:42:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anjana Hari <quic_ahari@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     oe-kbuild-all@...ts.linux.dev, alim.akhtar@...sung.com,
        avri.altman@....com, bvanassche@....org, konrad.dybcio@...aro.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_narepall@...cinc.com, quic_nitirawa@...cinc.com,
        quic_rampraka@...cinc.com, Anjana Hari <quic_ahari@...cinc.com>
Subject: Re: [PATCH v3 1/1] scsi: ufs: Add hibernation callbacks

Hi Anjana,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on next-20230120]
[cannot apply to jejb-scsi/for-next linus/master v6.2-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20230120-193447
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20230120113321.30433-2-quic_ahari%40quicinc.com
patch subject: [PATCH v3 1/1] scsi: ufs: Add hibernation callbacks
config: arc-randconfig-r043-20230119 (https://download.01.org/0day-ci/archive/20230121/202301211209.zKDppcLI-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/239ad2244616006dd39bc9a5380108435d168a86
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20230120-193447
        git checkout 239ad2244616006dd39bc9a5380108435d168a86
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/ufs/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/ufs/core/ufshcd.c: In function 'ufshcd_system_freeze':
>> drivers/ufs/core/ufshcd.c:10004:15: error: implicit declaration of function 'ufshcd_system_suspend'; did you mean 'trace_ufshcd_system_suspend'? [-Werror=implicit-function-declaration]
   10004 |         ret = ufshcd_system_suspend(dev);
         |               ^~~~~~~~~~~~~~~~~~~~~
         |               trace_ufshcd_system_suspend
   drivers/ufs/core/ufshcd.c: In function 'ufshcd_system_restore':
>> drivers/ufs/core/ufshcd.c:10017:16: error: implicit declaration of function 'ufshcd_system_resume'; did you mean 'ufshcd_system_restore'? [-Werror=implicit-function-declaration]
   10017 |         return ufshcd_system_resume(dev);
         |                ^~~~~~~~~~~~~~~~~~~~
         |                ufshcd_system_restore
   cc1: some warnings being treated as errors


vim +10004 drivers/ufs/core/ufshcd.c

  9993	
  9994		struct ufs_hba *hba = dev_get_drvdata(dev);
  9995		int ret = 0;
  9996	
  9997		/*
  9998		 * Run time resume the controller to make sure
  9999		 * the PM work queue threads do not try to resume
 10000		 * the child (scsi host), which leads to errors as
 10001		 * the controller is not yet resumed.
 10002		 */
 10003		pm_runtime_get_sync(hba->dev);
 10004		ret = ufshcd_system_suspend(dev);
 10005		pm_runtime_put_sync(hba->dev);
 10006	
 10007		return ret;
 10008	}
 10009	EXPORT_SYMBOL_GPL(ufshcd_system_freeze);
 10010	
 10011	int ufshcd_system_restore(struct device *dev)
 10012	{
 10013	
 10014		struct ufs_hba *hba = dev_get_drvdata(dev);
 10015	
 10016		hba->restore = true;
 10017		return ufshcd_system_resume(dev);
 10018	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests