linux-kernel - Re: [PATCH] gpiolib: fix linker errors when GPIOLIB is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Jan 2023 00:29:45 +0000
From:   Pierluigi Passaro <pierluigi.p@...iscite.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
CC:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Eran Matityahu <eran.m@...iscite.com>,
        Nate Drude <Nate.D@...iscite.com>,
        Francesco Ferraro <francesco.f@...iscite.com>,
        "pierluigi.passaro@...il.com" <pierluigi.passaro@...il.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] gpiolib: fix linker errors when GPIOLIB is disabled

On Wed, Jan 18, 2023 at 3:22 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Tue, Jan 17, 2023 at 11:17 AM Pierluigi Passaro
> <pierluigi.p@...iscite.com> wrote:
> >
> > On Tue, Jan 17, 2023 at 10:36 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > > On Mon, Jan 16, 2023 at 3:08 PM Pierluigi Passaro
> > > <pierluigi.p@...iscite.com> wrote:
> > > >
> > > > Both the functions gpiochip_request_own_desc and
> > > > gpiochip_free_own_desc are exported from
> > > >     drivers/gpio/gpiolib.c
> > > > but this file is compiled only when CONFIG_GPIOLIB is enabled.
> > > > Move the protototypes under "#ifdef CONFIG_GPIOLIB" and provide
> > > > reasonable definitions in the "#else" branch.
> > > >
> > > > Signed-off-by: Pierluigi Passaro <pierluigi.p@...iscite.com>
> > > > Reported-by: kernel test robot <lkp@...el.com>
> > >
> > > Please add a Fixes tag.
> > >
> > I beg your pardon for the question: how can I "add a Fixes tag" ?
> > Can you point me to any reference documentation / instructions ?
> > Thanks
> > >
>
> Look at the output of `git blame` on the file in question and see who
> added the changes that introduced the problem. Then, before your
> Sign-off in the git message add: Fixes: <12 chars of the commit hash>
> ("<commit subject>"). See Existing commits with fixes for reference.
>
> Bart
>
Thanks for the guidelines: I've just sent patch v2 with Fixes tag.