[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2d05a943-3510-5ee9-9906-247a6344190a@linaro.org>
Date: Sun, 22 Jan 2023 15:16:14 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Astrid Rost <astrid.rost@...s.com>,
Mark Brown <broonie@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Dylan Reid <dgreid@...omium.org>
Cc: kernel@...s.com, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type
On 20/01/2023 11:25, Astrid Rost wrote:
> Add jack-type: Bitmap value of snd_jack_type to allow combining
> card drivers to create a jack for it.
Subject: drop "yaml". We do not filename extensions to subject prefix.
Nowhere.
>
> Signed-off-by: Astrid Rost <astrid.rost@...s.com>
> ---
> Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> index 785930658029..1d949b805f98 100644
> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> @@ -27,6 +27,14 @@ properties:
> interrupts:
> maxItems: 1
>
> + jack-type:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Bitmap value of snd_jack_type to allow combining
> + card drivers to create a jack for it. Supported is
Why the device would once support (allow) headphone and once not? Device
either always supports them or never...
> + 1 SND_JACK_HEADPHONE
> + 2 SND_JACK_MICROPHONE
minimum and maximum
> + default: 3
> +
> ti,micbias:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: Intended MICBIAS voltage (datasheet section 9.6.7).
Best regards,
Krzysztof
Powered by blists - more mailing lists